Automated DevTools release process #22161
Merged
Conversation
bvaughn
force-pushed the
bvaughn:devtools-release-script
branch
from
9ac913e
to
51c5d42
|
Comparing: bd5bf55...42cea6e Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
looks pretty great so far! pre-emptive approval. one suggestion is that you might want to change the title of the PR? |
| @@ -4,48 +4,49 @@ | |||
| "description": "Adds React debugging tools to the Chrome Developer Tools.", | |||
bvaughn
Aug 24, 2021
•
Author
Contributor
Yes. I updated the manifest.json files in their own commit to match the format generated by JSON.stringify(json, null, 2) so the version update script would only affect version numbers (and no other formatting changes).
| }); | ||
| } | ||
|
|
||
| function updatePackageVersions(previousVersion, nextVersion) { |
Thanks! Yeah, GitHub defaults a PR title to the first commit |
bvaughn
changed the title
|
awesome, thanks!! |
bvaughn
merged commit b5fbf54
into
facebook:main
34 checks passed
34 checks passed
ci/circleci: yarn_test--r=experimental --env=development --persistent
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=stable --env=development --persistent
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=development --variant=false
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=development --variant=true
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=production --variant=false
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=production --variant=true
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-modern --env=development --variant=false
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-modern --env=development --variant=true
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-modern --env=production --variant=false
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-modern --env=production --variant=true
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build---project=devtools -r=experimental
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build--r=experimental --env=development
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build--r=experimental --env=production
Your tests passed on CircleCI!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
yarn buildandnpm publishstepsdevtools-release-script.mp4