Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: correct JavaScript primitive value names in n-api.md #39129

Closed
wants to merge 1 commit into from

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Jun 23, 2021

  1. Correct JavaScript primitive value names to reflect their actual types rather than the Built-in object.
  2. napi_throw can receive arbitrary JavaScript values, but not limited to objects.
  3. symbol values are not objects.
  4. this may be arbitrary JavaScript values when invoking functions (although ToObject will be performed on that value so that in the function this will always be an object).
@legendecas legendecas force-pushed the legendecas:doc/napi-symbol branch from 7c7a44a to 566f634 Jun 23, 2021
@lpinca
lpinca approved these changes Jun 24, 2021
@legendecas
Copy link
Member Author

@legendecas legendecas commented Jun 29, 2021

Copy link
Member

@mhdawson mhdawson left a comment

LGTM

mhdawson added a commit that referenced this pull request Jun 30, 2021
PR-URL: #39129
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson
Copy link
Member

@mhdawson mhdawson commented Jun 30, 2021

Landed in 0e7238a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants