Hi @junaidbinfarooq!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

I'm not sure why the "sync_reconciler_forks" CI task is failing but I don't think we can land this PR while it is (or it would break the main branch).

Comparing: 4df10c5...23d67be

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 23d67be

I'm not sure why the "sync_reconciler_forks" CI task is failing but I don't think we can land this PR while it is (or it would break the main branch).

It says this in CircleCI:

It says this in CircleCI

Right. I saw the text, but it doesn't make sense given the file (and the change) that was made.

It says this in CircleCI

Right. I saw the text, but it doesn't make sense given the file (and the change) that was made.

Exactly, that is what I was thinking too.

Running the suggested command applies changes to various files in the react-reconciler package like changing ReactFiberLane.old to ReactFiberLane.new.

Is there any way to fix the said build issue?

Is there any way to fix the said build issue?

Sorry. I don't know or I would have suggested a fix. 😦

Is there any way to fix the said build issue?

Sorry. I don't know or I would have suggested a fix.

Perhaps, creating a branch directly and subsequently a new pr on the said repo without a fork can prevent this issue?

This is definitely a problem with our yarn replace-fork script. It also impacts #22151 and can be reproduced by modifying any file in the fixtures folder and running yarn replace-fork, which updates a bunch of the .old.js files to import .new.js modules (which it should not do).

Edit: #22151 (comment)

Now that #22156 has landed, if you rebase on HEAD of main branch you'll see the underlying error here in CI (or when you run yarn replace-fork)

I guess it's probably fine to sync this, since linc only lints changed files in a branch.