Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera.changed event not firing when camera.roll equals 0 #9403

Open
TJPovey opened this issue Mar 4, 2021 · 0 comments
Open

Camera.changed event not firing when camera.roll equals 0 #9403

TJPovey opened this issue Mar 4, 2021 · 0 comments

Comments

Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@TJPovey
Copy link

@TJPovey TJPovey commented Mar 4, 2021

When camera.roll = 0, the camera.changed event doesn't fire when changes only occur to the heading. e.g. if the user is looking down and rotates the camera. This causes issues with our compass not updating.

Sandcastle example:

Try the rotate buttons in the sandcastle below, you'll see that the camera.changed event is fired only when the roll =/= 0:
Sandcastle

Rotating with the middle mouse button will cause the changed event not to be fired, as expected. The rotate buttons are there for convenience.

Assuming this is related to #9365

Browser:
Chrome: Version 88.0.4324.190

Operating System:
Windows 10
Version: 1803
OS build: 17134.1304

Thanks,
Tom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment