Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(fluttercountertutorial): specify file paths for each section #2663

Merged
merged 2 commits into from Aug 13, 2021

Conversation

@juliangeissler
Copy link
Contributor

@juliangeissler juliangeissler commented Aug 13, 2021

Status

READY

Breaking Changes

NO

Description

The tutorial starts by creating a brand new flutter project but then it tells you copy paste the pubspec from the bloc github, where the versions specified. I think for this type of "create a project" tutorial you need specific versions. The down side is updating the versions.

I was also missing which files i needed to create so I added a paragraph where it was missing.

In general the whole concept of the tutorial could be changed, since it would be better to just tell the reader to clone the bloc repo, and open Android Studio with the right example folder and then explain each file

Type of Change

  • New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
@juliangeissler juliangeissler requested a review from felangel as a code owner Aug 13, 2021
@felangel felangel changed the title Update Flutter Count Tutorial docs(fluttercountertutorial): specify file paths for each section Aug 13, 2021
@felangel felangel added this to In progress in Upgrade Documentation via automation Aug 13, 2021
Copy link
Owner

@felangel felangel left a comment

LGTM :shipit:

@felangel felangel merged commit 34e6c8a into felangel:master Aug 13, 2021
3 checks passed
3 checks passed
@github-actions
build
Details
@github-actions
pana
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
Upgrade Documentation automation moved this from In progress to Done Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants