Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: uvwasi honours node_shared_libuv #39260

Closed
wants to merge 1 commit into from
Closed

build: uvwasi honours node_shared_libuv #39260

wants to merge 1 commit into from

Conversation

@kapouer
Copy link
Contributor

@kapouer kapouer commented Jul 4, 2021

Fix #39248.
@kapouer
build: uvwasi honours node_shared_libuv
c1b5978 
Fix #39248.
@richardlau
richardlau approved these changes Jul 4, 2021
View changes
@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Jul 4, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38849/

@tniessen tniessen requested a review from cjihrig Jul 5, 2021
@tniessen
tniessen approved these changes Jul 5, 2021
View changes
@cjihrig
cjihrig approved these changes Jul 5, 2021
View changes
@jasnell
jasnell approved these changes Jul 8, 2021
View changes
@github-actions
Copy link

@github-actions github-actions bot commented Jul 8, 2021

Landed in 6e1906c...f65d748

@github-actions github-actions bot closed this Jul 8, 2021
nodejs-github-bot added a commit that referenced this pull request Jul 8, 2021
@kapouer @nodejs-github-bot
build: uvwasi honours node_shared_libuv
f65d748 
Fix #39248.

PR-URL: #39260
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Jul 11, 2021
@kapouer @targos
build: uvwasi honours node_shared_libuv
a7cd40e 
Fix #39248.

PR-URL: #39260
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jul 13, 2021
Merged
This was referenced Aug 19, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Aug 19, 2021
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@cjihrig cjihrig

@tniessen tniessen

@richardlau richardlau

Assignees
No one assigned
Labels
needs-ci wasi
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

shared-libuv is ignored by uvwasi.gyp
6 participants
@kapouer @nodejs-github-bot @jasnell @cjihrig @tniessen @richardlau