Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove instructions for unsupported Node.js versions #39185

Merged
merged 1 commit into from Jun 30, 2021
Merged

Conversation

@Trott
Copy link
Member

@Trott Trott commented Jun 28, 2021

Remove special V8 maintenance instructions for versions of Node.js prior
to 9.0.0. Perform other minor edits in nearby text.

@github-actions github-actions bot added the doc label Jun 28, 2021
Copy link
Member

@mhdawson mhdawson left a comment

LGTM

@lpinca
lpinca approved these changes Jun 29, 2021
@Flarna
Flarna approved these changes Jun 30, 2021
Remove special V8 maintenance instructions for versions of Node.js prior
to 9.0.0. Perform other minor edits in nearby text.

PR-URL: #39185
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@Trott Trott force-pushed the Trott:de-9 branch from e036fe8 to 88425c7 Jun 30, 2021
@Trott
Copy link
Member Author

@Trott Trott commented Jun 30, 2021

Landed in 88425c7

@Trott Trott merged commit 88425c7 into nodejs:master Jun 30, 2021
13 checks passed
13 checks passed
@github-actions
build-tarball
Details
@github-actions
lint-commit-message
Details
@github-actions
build-windows
Details
@github-actions
lint-addon-docs
Details
@github-actions
build-docs
Details
@github-actions
test-linux
Details
@github-actions
lint-cpp
Details
@github-actions
lint-md
Details
@github-actions
lint-js
Details
@github-actions
lint-py
Details
@github-actions
lint-sh
Details
@github-actions
lint-codeowners
Details
@github-actions
lint-pr-url
Details
@Trott Trott deleted the Trott:de-9 branch Jun 30, 2021
targos added a commit that referenced this pull request Jul 11, 2021
Remove special V8 maintenance instructions for versions of Node.js prior
to 9.0.0. Perform other minor edits in nearby text.

PR-URL: #39185
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants