doc: remove obsolete cc recommendations #39181
Merged
Conversation
|
@ofrobots Am I guessing correctly that you're not the person to CC/ping on these things anymore? Or should I leave this text alone? |
|
LGTM |
In 2016, Ali added the instruction to cc him on particular V8 bugs and the suggestion to contact him for certain problems. However, I'm pretty sure Ali has not been working on V8 for 2+ years at this point. I'm guessing those instructions are obsolete at this point. (I'll ping him in the PR for this change to confirm, though.) Also: Remove a parenthetical and add a comma, because I can't imagine opening a separate pull request to add a comma. (OK, I'm lying, I totally can and if anyone has done that in the past, it's probably me.) PR-URL: #39181 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 593212c |
targos
added a commit
that referenced
this pull request
Jul 11, 2021
In 2016, Ali added the instruction to cc him on particular V8 bugs and the suggestion to contact him for certain problems. However, I'm pretty sure Ali has not been working on V8 for 2+ years at this point. I'm guessing those instructions are obsolete at this point. (I'll ping him in the PR for this change to confirm, though.) Also: Remove a parenthetical and add a comma, because I can't imagine opening a separate pull request to add a comma. (OK, I'm lying, I totally can and if anyone has done that in the past, it's probably me.) PR-URL: #39181 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
In 2016, Ali added the instruction to cc him on particular V8 bugs and
the suggestion to contact him for certain problems. However, I'm pretty
sure Ali has not been working on V8 for 2+ years at this point. I'm
guessing those instructions are obsolete at this point. (I'll ping him
in the PR for this change to confirm, though.)
Also: Remove a parenthetical and add a comma, because I can't imagine
opening a separate pull request to add a comma. (OK, I'm lying, I
totally can and if anyone has done that in the past, it's probably me.)