Doc: Align the EventTarget.dispatchEvent doc with the actual behavior #39127
Conversation
|
Thanks, looking good. A few suggestions: |
|
@aduh95 I have made the changes you suggested. Please take a look at it and let me know if this needs any changes. |
|
@nodejs/events @jasnell FYI. |
|
Yeah this is leftovers from the NodeEventTarget split - good catch and fix! |
PR-URL: #39127 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in ffda9a8 |
targos
added a commit
that referenced
this pull request
Jul 11, 2021
PR-URL: #39127 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Aug 19, 2021
This was referenced Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #39125
Hi @aduh95 @aral @Ayase-252, how does this look?
Let me know if this needs any changes.
Thanks