Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go 1.16 to CI and drop 1.12 specific code #1850

Merged
merged 3 commits into from Apr 16, 2021
Merged

Conversation

@aldas
Copy link
Contributor

@aldas aldas commented Apr 15, 2021

Add Go 1.16 to CI and drop 1.12 specific code

I'll open this in favor of #1839

@aldas aldas requested a review from lammel Apr 15, 2021
@codecov
Copy link

@codecov codecov bot commented Apr 15, 2021

Codecov Report

Merging #1850 (621489e) into master (bb7f222) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1850   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files          32       31    -1     
  Lines        2686     2686           
=======================================
  Hits         2406     2406           
  Misses        180      180           
  Partials      100      100           
Impacted Files Coverage Δ
middleware/timeout.go 100.00% <ø> (ø)
middleware/csrf.go 80.28% <100.00%> (ø)
middleware/proxy.go 66.66% <100.00%> (+6.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb7f222...621489e. Read the comment docs.

@@ -302,3 +305,73 @@ func TestProxyRewriteRegex(t *testing.T) {
})
}
}

func TestProxy_1_11(t *testing.T) {

This comment has been minimized.

@lammel

lammel Apr 15, 2021
Contributor

Is this related to Go 1.11 somehow or why is its name suffixed with _1_11? (Just curios, looks like a normal proxy test)

@aldas aldas added this to the v4.3 milestone Apr 15, 2021
@lammel
Copy link
Contributor

@lammel lammel commented Apr 16, 2021

Say a final farewell to Go 1.12 or earlier. Merging.

@lammel lammel merged commit a4ab482 into labstack:master Apr 16, 2021
15 checks passed
15 checks passed
@github-actions
ubuntu-latest @ Go 1.13
Details
@github-actions
ubuntu-latest @ Go 1.14
Details
@github-actions
ubuntu-latest @ Go 1.15
Details
@github-actions
ubuntu-latest @ Go 1.16
Details
@github-actions
macos-latest @ Go 1.13
Details
@github-actions
macos-latest @ Go 1.14
Details
@github-actions
macos-latest @ Go 1.15
Details
@github-actions
macos-latest @ Go 1.16
Details
@github-actions
windows-latest @ Go 1.13
Details
@github-actions
windows-latest @ Go 1.14
Details
@github-actions
windows-latest @ Go 1.15
Details
@github-actions
windows-latest @ Go 1.16
Details
@github-actions
Benchmark comparison ubuntu-latest @ Go 1.16
Details
@codecov
codecov/patch 100.00% of diff hit (target 89.57%)
Details
@codecov
codecov/project 89.57% (+0.00%) compared to bb7f222
Details
@aldas aldas deleted the aldas:add_go16 branch May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants