ckerr
Follow
ckerr
Follow
Achievements
Achievements
Highlights
- Pro
Pinned
Build cross-platform desktop apps with JavaScript, HTML, and CSS
1,333 contributions in the last year
Less
More
Activity overview
Contribution activity
July 2021
Created a pull request in electron/bugbot that received 30 comments
feat: flexible commands in issue comments
Fixes #46. Fixes #72. Update the probot client's issue-parser so that it can return different command types. Previously it only did bisection reque…
+518
−178
•
30
comments
Opened 39 other pull requests in 3 repositories
electron/fiddle
2
open
16
merged
1
closed
- perf: remove getUpdatedElectronVersions
- test: simplify versions.ts logic and improve coverage
- refactor: default to latest stable version
- build: better fetch releases
- perf: prefer getKnownVersions() over getElectronVersions().
- chore: remove EditorMosaicMock; use EditorMosaic directly
- fix: publishing gists with empty files to Github
- fix: editors sometimes disappear when loading new fiddle
- fix: cannot read property 'set' of undefined
- fix: EditorMosaic safeguard against unwanted files
- fix: 'second handler for GET_APP_PATHS' err dialog
- fix: "second handler for GET_APP_PATHS" error dialog
- feat: support Electron 15 alpha releases
- refactor: replace decomment with strip-comments
- refactor: remove Sync() calls from readFiddle()
- chore: bump electron dep to 12.0.14
- feat: add --full command-line option
- chore: get version list from electronjs.org
- fix: when EditorState.setVersion() loads a template for the new version
electron/bugbot
2
open
17
merged
- test: add end-to-end integration tests
- feat(bot): remember bot issue comment ids
- update the 'package.json' files from depcheck runs
- refactor: put task-patching code to the Task class
- chore: increment number of supported branches to 4
- chore: add debug calls when new jobs are posted
- feat: run Test tasks in the runner
- feat: support + validate new test tasks in broker
- feat: have runner bisect w/obsolete, beta, nightly
- docs: move 'interface' doc from hackmd to the repo
- fix: unlikely but possible infinite versions loop
- feat: add code to pick Electron versions to test
- test: include integration tests in test coverage
- refactor: fix some warnings
- refactor(bot): add GithubClient.close() for shutting down tests
- test: refactor probot client to be easier to test
- test: add typescript-eslint/recommended-requiring-type-checking
- build: add 'tsc' to package.json's scripts
- fix: race conditions in tests
electron/apps
1
merged
Reviewed 52 pull requests in 10 repositories
electron/bugbot 22 pull requests
- refactor(bot): use prefix for GitHub client debug
- refactor(bot): move polling logic into helper func
- feat: run Test tasks in the runner
-
test(bot): add
/bugbot testpayload fixture - feat(bot): only allow commands for maintainers
- feat: flexible commands in issue comments
- feat: support + validate new test tasks in broker
- feat: use explicit token passed to broker in env
- feat: have runner bisect w/obsolete, beta, nightly
- fix: add tests to tsconfig but not build
- feat(bot): self-update bot comments
- chore: remove issue template
- chore: ignore config files in eslintrc
- feat: add code to pick Electron versions to test
- test(bot): use nock to test post-bisect Probot interactions
-
fix: define
enginesin globalpackage.json -
fix: include
/test/folder intsconfig.json - fix: uniformize bot debug prefix
- refactor: move issue parsing logic to bot module
- test: refactor probot client to be easier to test
- refactor: standardize output directory
- build: add 'tsc' to package.json's scripts
electron/electron 15 pull requests
- feat: support crashpad on linux
- fix: potential crash on macOS app exit
- fix: BrowserWindow transparency not working
- fix: pressing ESC should exit fullscreen from webview
- fix: double traffic lights on exit fullscreen
- fix: use correct userData path when unbundled
- chore: update releases to 8 weeks in CONTRIBUTING
- feat: enable windows control overlay on Windows
- chore: cherry-pick 9bab573a37 from chromium
- docs: Update timeline for E15 alpha announcement
- feat: expose location and modifiers on before-input-event
- build: decode error output as utf8
- chore: cherry-pick 9bab573a37 from chromium
- test: fix check for electron_common_testing binding in logging-spec.ts
- chore: disable fullscreen test on mac arm
electron/fiddle 7 pull requests
electron/apps 2 pull requests
electron/hubdown 1 pull request
electron/unreleased 1 pull request
electron/electronjs.org 1 pull request
electron/symbol-server 1 pull request
electron/node-rcedit 1 pull request
electron/electron-packager 1 pull request
Created an issue in electron/bugbot that received 3 comments
probot client testing is poor
Right now the probot client's testing coverage is ~35%. It's difficult to make changes that effect the probot client + other modules (or just the p…
3
comments
Opened 20 other issues in 2 repositories
electron/bugbot
7
open
5
closed
- when a new issue is reported, add labels based on template values
- bug: some version + test combos block runner with Uncaught Exception popup dialog
- feat: broker must accept posted Test jobs
- feat: bot must detect issue comments from maintainers
- feat: Runner support for running individual tests
-
feat: add
/bugbot testto probot client - discussion: test matrix markdown appearance
- Probot Client should be able to update its own comment
- re-enable warnings disabled in .eslintrc + fix the warnings
- feat: persistent logging for the broker
- feat: log bugbot usage
- should issue-parser be in bot/ instead of shared/?
electron/fiddle
3
open
5
closed
- [bug]: TypeError: Cannot read property 'version' of undefined
- bug: "Publishing Fiddle to GitHub failed. Are you connected to the internet?"
- bug: TypeError: Cannot read property 'set' of undefined
- bug: editor context menus do not work
- bug: "TypeError: Cannot read property 'getValue' of null"
- error when opening second window: "Attempted to register a second handler for 'GET_APP_PATHS'"
- use https://electronjs.org/headers/index.json to get version info
- output console is rebuilt frequently
3
contributions
in private repositories
Jul 12 – Jul 14