Skip to content

/ react

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new effect fields to old fork, and vice versa #20246

Merged
merged 2 commits into from Nov 13, 2020
Merged

Add new effect fields to old fork, and vice versa #20246

merged 2 commits into from Nov 13, 2020

Conversation

@acdlite
Copy link
Member

@acdlite acdlite commented Nov 13, 2020

We need to bisect the changes to the recent commit phase refactor. To do this, we'll need to add back the effect list temporarily.

This makes it so the memory usage is the same in both forks.
@acdlite
Add new effect fields to old fork
2ae3590 
So that when comparing relative performance, we don't penalize the new
fork for using more memory.
@acdlite acdlite requested review from bvaughn and rickhanlonii Nov 13, 2020
@codesandbox
Copy link

@codesandbox codesandbox bot commented Nov 13, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ccf2440:

Sandbox Source
React Configuration
@bvaughn
bvaughn approved these changes Nov 13, 2020
View changes
packages/react-reconciler/src/ReactFiber.new.js
@@ -141,6 +141,10 @@ function FiberNode(

// Effects
this.flags = NoFlags;
this.nextEffect = null;

This comment has been minimized.

Sign in to view
@bvaughn

bvaughn Nov 13, 2020
Contributor

Always wondered about this newline 😆
@sizebot
Copy link

@sizebot sizebot commented Nov 13, 2020 •
edited

Warnings
⚠️ Could not find build artifacts for base commit: 2fbcc98

Size changes (stable)

Generated by 🚫 dangerJS against ccf2440

@sizebot
Copy link

@sizebot sizebot commented Nov 13, 2020 •
edited

Details of bundled changes.

Comparing: 2fbcc98...ccf2440

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-prod.js 🔺+0.1% 🔺+0.1% 267.09 KB 267.46 KB 47.69 KB 47.75 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js +0.1% +0.1% 278.62 KB 278.99 KB 49.9 KB 49.95 KB RN_OSS_PROFILING
ReactFabric-dev.js +0.1% 0.0% 656.25 KB 656.6 KB 141.9 KB 141.96 KB RN_OSS_DEV
ReactFabric-prod.js 🔺+0.1% 🔺+0.1% 260.91 KB 261.28 KB 46.43 KB 46.48 KB RN_OSS_PROD
ReactFabric-profiling.js +0.1% +0.1% 272.3 KB 272.67 KB 48.63 KB 48.68 KB RN_OSS_PROFILING
ReactNativeRenderer-dev.js +0.1% 0.0% 675.51 KB 675.86 KB 146.54 KB 146.6 KB RN_OSS_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-test-utils.development.js 0.0% 0.0% 66.11 KB 66.11 KB 18.8 KB 18.8 KB NODE_DEV
ReactDOMTesting-dev.js 0.0% 0.0% 907.02 KB 907.28 KB 204.29 KB 204.33 KB FB_WWW_DEV
ReactDOM-dev.js 0.0% 0.0% 954 KB 954.34 KB 213.4 KB 213.46 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.01 KB 1.01 KB 617 B 615 B NODE_PROD
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 366.61 KB 366.91 KB 68.12 KB 68.18 KB FB_WWW_PROD
ReactDOM-profiling.js +0.1% +0.1% 382.91 KB 383.21 KB 71.11 KB 71.15 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 144.37 KB 144.37 KB 36.71 KB 36.71 KB UMD_DEV
react-dom-server.node.development.js 0.0% -0.0% 138.23 KB 138.23 KB 36.52 KB 36.52 KB NODE_DEV
react-dom-server.browser.development.js 0.0% -0.0% 136.96 KB 136.96 KB 36.27 KB 36.27 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 20.18 KB 20.18 KB 7.48 KB 7.47 KB NODE_PROD
react-dom-test-utils.development.js 0.0% -0.0% 71.29 KB 71.29 KB 19.31 KB 19.31 KB UMD_DEV
ReactDOMServer-dev.js 0.0% -0.0% 141.4 KB 141.4 KB 36.3 KB 36.3 KB FB_WWW_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 13.71 KB 13.71 KB 5.32 KB 5.32 KB UMD_PROD
ReactDOMServer-prod.js 0.0% -0.0% 46.28 KB 46.28 KB 10.79 KB 10.79 KB FB_WWW_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 13.7 KB 13.7 KB 5.27 KB 5.26 KB NODE_PROD
ReactDOMTesting-prod.js 🔺+0.1% 🔺+0.1% 368.09 KB 368.38 KB 69.73 KB 69.79 KB FB_WWW_PROD
react-dom.development.js 0.0% 0.0% 949.23 KB 949.6 KB 208.1 KB 208.17 KB UMD_DEV
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 121.23 KB 121.36 KB 39.84 KB 39.87 KB UMD_PROD
react-dom.profiling.min.js +0.1% +0.1% 126.54 KB 126.68 KB 41.51 KB 41.55 KB UMD_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 5.07 KB 5.07 KB 1.74 KB 1.74 KB UMD_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.35 KB 5.35 KB 1.8 KB 1.8 KB NODE_DEV
react-dom.development.js 0.0% 0.0% 903.29 KB 903.63 KB 205.53 KB 205.59 KB NODE_DEV
ReactDOMForked-dev.js 0.0% 0.0% 969.08 KB 969.28 KB 215.25 KB 215.29 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.22 KB 1.22 KB 712 B 711 B UMD_PROD
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 121.4 KB 121.53 KB 39.09 KB 39.13 KB NODE_PROD
ReactDOMForked-prod.js 0.0% 0.0% 370.46 KB 370.53 KB 68.91 KB 68.92 KB FB_WWW_PROD
react-dom.profiling.min.js +0.1% +0.1% 126.9 KB 127.04 KB 40.78 KB 40.83 KB NODE_PROFILING
ReactDOMForked-profiling.js 0.0% 0.0% 389.12 KB 389.18 KB 72.11 KB 72.13 KB FB_WWW_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.6 KB 4.6 KB 1.64 KB 1.64 KB NODE_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js 0.0% 0.0% 603.79 KB 604.06 KB 127.25 KB 127.29 KB UMD_DEV
ReactTestRenderer-dev.js 0.0% 0.0% 584.82 KB 585.09 KB 126.64 KB 126.69 KB RN_FB_DEV
ReactTestRenderer-prod.js 🔺+0.2% 🔺+0.1% 228.22 KB 228.59 KB 41.69 KB 41.74 KB RN_FB_PROD
ReactTestRenderer-profiling.js +0.2% +0.1% 239.62 KB 239.99 KB 43.86 KB 43.91 KB RN_FB_PROFILING
react-test-renderer.production.min.js 🔺+0.2% 🔺+0.1% 76.11 KB 76.24 KB 23.93 KB 23.96 KB UMD_PROD
react-test-renderer.development.js 0.0% 0.0% 575.15 KB 575.42 KB 125.79 KB 125.83 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.2% 🔺+0.2% 75.91 KB 76.04 KB 23.63 KB 23.68 KB NODE_PROD
ReactTestRenderer-dev.js 0.0% 0.0% 590.18 KB 590.44 KB 126.88 KB 126.92 KB FB_WWW_DEV

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.production.min.js 🔺+0.2% 🔺+0.2% 75.41 KB 75.54 KB 23.44 KB 23.49 KB NODE_PROD
react-art.development.js +0.1% 0.0% 686.4 KB 686.76 KB 145.85 KB 145.9 KB UMD_DEV
react-art.production.min.js 🔺+0.1% 🔺+0.1% 110.52 KB 110.66 KB 34.37 KB 34.4 KB UMD_PROD
react-art.development.js +0.1% 0.0% 587.75 KB 588.1 KB 128.01 KB 128.07 KB NODE_DEV
ReactART-dev.js +0.1% +0.1% 621.05 KB 621.4 KB 132.3 KB 132.37 KB FB_WWW_DEV
ReactART-prod.js 🔺+0.1% 🔺+0.1% 229.79 KB 230.09 KB 40.81 KB 40.87 KB FB_WWW_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler-reflection.production.min.js 0.0% -0.1% 2.8 KB 2.8 KB 1.16 KB 1.15 KB NODE_PROD
react-reconciler.development.js +0.1% 0.0% 645.32 KB 645.67 KB 137.95 KB 138.01 KB NODE_DEV
react-reconciler.production.min.js 🔺+0.2% 🔺+0.2% 85.33 KB 85.47 KB 26.32 KB 26.37 KB NODE_PROD
react-reconciler.profiling.min.js +0.1% +0.2% 90.82 KB 90.95 KB 28.02 KB 28.06 KB NODE_PROFILING

Size changes (experimental)

Generated by 🚫 dangerJS against ccf2440

@acdlite
Add firstEffect, et al fields to new fork
Loading status checks…
ccf2440 
We need to bisect the changes to the recent commit phase refactor. To
do this, we'll need to add back the effect list temporarily.

This only adds them to the Fiber type so that the memory is the same
as the old fork.
@acdlite acdlite force-pushed the acdlite:same-fiber-fields branch from 1acb029 to ccf2440 Nov 13, 2020
@acdlite acdlite merged commit 3ebf051 into facebook:master Nov 13, 2020
34 checks passed
34 checks passed
Facebook CLA Check Contributor License Agreement is valid!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_build Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_lint_build Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: build_devtools_and_process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: build_devtools_scheduling_profiler Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: sizebot_stable Your tests passed on CircleCI!
Details
ci/circleci: yarn_build Your tests passed on CircleCI!
Details
ci/circleci: yarn_flow Your tests passed on CircleCI!
Details
ci/circleci: yarn_lint Your tests passed on CircleCI!
Details
ci/circleci: yarn_lint_build Your tests passed on CircleCI!
Details
ci/circleci: yarn_test Your tests passed on CircleCI!
Details
ci/circleci: yarn_test-classic Your tests passed on CircleCI!
Details
ci/circleci: yarn_test-classic_prod Your tests passed on CircleCI!
Details
ci/circleci: yarn_test-classic_prod_variant Your tests passed on CircleCI!
Details
ci/circleci: yarn_test-classic_variant Your tests passed on CircleCI!
Details
ci/circleci: yarn_test-stable Your tests passed on CircleCI!
Details
ci/circleci: yarn_test-stable_build Your tests passed on CircleCI!
Details
ci/circleci: yarn_test-stable_build_prod Your tests passed on CircleCI!
Details
ci/circleci: yarn_test-stable_persistent Your tests passed on CircleCI!
Details
ci/circleci: yarn_test-stable_prod Your tests passed on CircleCI!
Details
ci/circleci: yarn_test-www Your tests passed on CircleCI!
Details
ci/circleci: yarn_test-www_prod Your tests passed on CircleCI!
Details
ci/circleci: yarn_test-www_prod_variant Your tests passed on CircleCI!
Details
ci/circleci: yarn_test-www_variant Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build_devtools Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_prod Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn

@rickhanlonii rickhanlonii

Assignees
No one assigned
Labels
CLA Signed React Core Team
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@acdlite @sizebot @bvaughn @facebook-github-bot
You can’t perform that action at this time.