🎉 Description

The ECDSA contract has a function toEthSignedMessage(bytes32), but we should have a function that works for any length of a bytes array:

function toEthSignedMessage(bytes s) pure internal returns (bytes32) {
  return keccak256(
    "\x19Ethereum Signed Message:\n",
    uintToBytes(s.length),
    s);
}

Where uintToBytes is implemented from an ideally

This would increase readability in bigger tests, such as those in semanticTests/externalContracts.

// -- Double reserve
// account: 1
// reserve(string), 69 ether: 0x20, 3, "abc" ->
// owner(string): 0x20, 3, "abc" -> 0x1212121212121212121212121212120000000012
// account: 0
// -- Transfer
// setContent(string,bytes32): 0x40, 0, 3, "abc" ->
// transfer(string,address): 0x40, 555, 3

Hi, just wondering why there are no tests in the scaffolded project when running truffle init...

Can I make a PR adding this? Where in the main truffle source code should I put this file?

thanks!

Description
Add a contract similar to Aave's AddressProvider or Uniswap's getPair() functionality.

Motivation
On-chain lookups of price oracles given the asset addresses.

Justification
String manipulation is difficult and expensive in Solidity, and you usually work with the token address, not its string name.

This is a bug report of an edge case that can only happen if you have a hardhat project inside a monorepo, and the hardhat project is also an npm project p.

If a solidity file within p imports another one using import "p/contracts/...", the compilation will fail. The reason for this is that the file ends up with two source names p/contract/... and contracts/....

This only happens w

From @Arachnid recent tweet, it looks like there is not good up to date solution to generate doc from natspec. We should explore the current solutions and create something on top of slither

Overview

If I import a file that has a constructor and just that file, and try to compile and deploy, brownie ignores it.

Specification

Here's what a file that brownie would ignore looks like:

pragma solidity 0.4.24;

import "@chainlink/contracts/src/v0.4/Oracle.sol";

(I remapped chainlink contacts so I could use the @ syntax)

However, Oracle.sol has a constructo

We can safely disallow any use of solc below 0.4.25.

I left a review and then got this message

which seems strange as it's telling me something I know.