Skip to content

/ components Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cdk/testing): Get webdriver test suite running with dummy tests #22344

Merged
merged 5 commits into from Mar 30, 2021
Merged

test(cdk/testing): Get webdriver test suite running with dummy tests #22344

merged 5 commits into from Mar 30, 2021

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Mar 25, 2021 •
edited

HUGE thanks to @kyliau for the example I used as a reference (https://github.com/kyliau/angular-wait/blob/main/test/test.ts) and @devversion for getting it to actually run in Bazel.

Me trying to set up WebDriver tests in Bazel:
Fail at drinking water
@google-cla google-cla bot added the cla: yes label Mar 25, 2021
@mmalerba
test(cdk/testing): Get webdriver test suite running with dummy tests
b616d42
@google-cla
Copy link

@google-cla google-cla bot commented Mar 29, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Mar 29, 2021
@mmalerba mmalerba changed the title WIP: attempting to get webdriver tests running test(cdk/testing): Get webdriver test suite running with dummy tests Mar 29, 2021
devversion and others added 3 commits Mar 29, 2021
@devversion @mmalerba
test(cdk/testing): Get webdriver test running
ee61bb6
@mmalerba
test(cdk/testing): Use a data URL in the placeholder test
9eeb474
@mmalerba
test(cdk/testing): Classify as e2e tests
332067d
@google-cla
Copy link

@google-cla google-cla bot commented Mar 29, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

@google-cla google-cla bot commented Mar 29, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@mmalerba mmalerba marked this pull request as ready for review Mar 29, 2021
@mmalerba mmalerba requested a review from devversion as a code owner Mar 29, 2021
@mmalerba
Copy link
Contributor Author

@mmalerba mmalerba commented Mar 29, 2021

ready for review

devversion
devversion approved these changes Mar 29, 2021
View changes
src/cdk/testing/tests/webdriver.e2e.spec.ts Outdated Show resolved Hide resolved
@mmalerba
test(cdk/testing): fix the test
c9a4d7e
@google-cla
Copy link

@google-cla google-cla bot commented Mar 30, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@mmalerba mmalerba added cla: yes and removed cla: no labels Mar 30, 2021
@mmalerba mmalerba merged commit 368cd38 into angular:webdriver-harness-environment Mar 30, 2021
16 checks passed
@mmalerba mmalerba deleted the webdriver branch Mar 30, 2021
mmalerba added a commit that referenced this issue Mar 31, 2021
@mmalerba @devversion
test(cdk/testing): Get webdriver test suite running with dummy tests (#…
4d34726 
…22344)

Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com>
mmalerba added a commit that referenced this issue Apr 8, 2021
@mmalerba @devversion
feat(cdk/testing): create a webdriver harness environment (#22410)
91969f3 
* feat(cdk/testing): create a webdriver harness environment (#22321)

* test(cdk/testing): Get webdriver test suite running with dummy tests (#22344)

Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com>

* test(cdk/testing): start the e2e-app and run webdriver tests in bazel (#22367)

* test(cdk/testing): port the protractor tests to the webdriver env (#22375)

* test(cdk/testing): enable webdriver tests on CI (#22379)

Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com>

* fixup! test(cdk/testing): enable webdriver tests on CI (#22379)

Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com>
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Apr 30, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion

Assignees
No one assigned
Labels
cla: yes target: feature branch
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@mmalerba @devversion