dnfield
Follow
Pinned
1,434 contributions in the last year
Less
More
Activity overview
Contribution activity
May 2021
Created 13 commits in 4 repositories
Created a pull request in flutter/flutter that received 6 comments
Opened 10 other pull requests in 4 repositories
flutter/flutter
5
merged
flutter/engine
2
open
1
merged
dnfield/flutter_svg
1
merged
dnfield/dart_path_parsing
1
merged
Reviewed 21 pull requests in 7 repositories
flutter/flutter 10 pull requests
- Added binary platform channels test
- Reland GC benchmark changes again
- Mark flutter docs test as flaky.
- Implement ==/hashCode for ViewConfiguration, avoid unnecessary layer creation/replacement
- Refactor MethodChannel and remove redundant OptionalMethodChannel methods
- Link to correct extended integration test driver file in integration_test README
- Added performance benchmarks for platform channels
- [integration_test] Don't log exceptions twice
- [flutter drive] Do not start dds if --no-dds
- Revert "Fix benchmark"
flutter/engine 4 pull requests
flutter/infra 2 pull requests
dnfield/flutter_svg 2 pull requests
flutter/buildroot 1 pull request
dnfield/dart_path_parsing 1 pull request
flutter/cocoon 1 pull request
Created an issue in flutter/flutter that received 9 comments
Tests launched with flutter drive cannot connect to their own VM Service.
This is probably because of DDS, but potentially because of ADB. I'll add a test case for this once I figure out which one.
9
comments
Opened 9 other issues in 2 repositories
flutter/flutter
6
open
2
closed
- Waiting for green bot landed a PR with a failing check
- Remove the WIP app from our repo/org
- EmbedderTest.FrameInfoContainsValidWidthAndHeight flaked on presubmit
- SceneBuilder.push* should return a non-nullable type
- Flake in docs shard
- Infra should do a smoke test that we can connect to critical services
-
RasterCache should take the total size of an
SkPictureinto account when deciding whether to rasterize it. - integration_test tests should report old/new gen GCs