Replace checkout with switch/restore #791
Conversation
Signed-off-by: Outsider <outsideris@gmail.com>
|
Thank you for this PR, @outsideris! Before merging, I'd like to confirm with the @github/ps-implementation-engineers that this change works for them. We may also want to make sure this change is implemented in the training manual for consistency. @github/ps-implementation-engineers, what do you think? cc @github/ps-programs |
|
Thank you for these contributions, @outsideris! I can’t vouch for the non-english translations, but the commands looks great! @brianamarie Can you verify that is it safe to make changes to Git commands in the non-english versions before we merge? I know some repos take care of the translations in a separate process, using the english version to reference what needs to be updated. Not sure if that’s the case here. |
This is on our radar. |
|
Thank you @outsideris for helping with this! There are 2 commands that need to be straightened out, which looks like you're aware of: I can only read 2 other languages where this does not line up, so I made suggestions in the Malay and Chinese versions. But I think it needs to be corrected for other languages too. |
|
@rwnfoo Good point!! I will change other languages as well even I can read only English and Korean. |
Co-authored-by: Rowena Foo <rwnfoo@github.com>
Signed-off-by: Outsider <outsideris@gmail.com>
|
I fixed creating a branch with |
|
Thank you so much @outsideris for the work! @parkerbxyz - Wondering if we should hold on this PR until |
|
Looks good. Thanks for your contributions, everyone! |
@rwnfoo Let’s proceed here like we did in githubtraining/training-manual#281 and ship it! |
Overview
TL;DR
Replace
checkoutwithswitchandrestorebecause the latest git encourages to useswitch/restoreinsteadcheckout.Questions
Next Steps
I can't change PDF files, because I don't know how I can generate them.
Review
I tried to change them in all supported languages using Google Translate.
But I'm not sure because I can read only Korean and English.