Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL support improvement #606

Open
1 of 2 tasks
Tibing opened this issue Aug 6, 2018 · 0 comments
Open
1 of 2 tasks

RTL support improvement #606

Tibing opened this issue Aug 6, 2018 · 0 comments

Comments

@Tibing
Copy link
Task lists! Give feedback
Member

@Tibing Tibing commented Aug 6, 2018

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

Issue description

Current behavior:
For now, we have only NbLayoutDirectionService which provides information about a state of our layout. So, when we using ChangeDetectionStrategy.OnPush in component and wanna use layout service we have to trigger change detection manually or use async pipe, for example.

Expected behavior:
I want to suggest building two directives: nbIfRtl and nbIfLtr. Both this directives have to support 'else' syntax like ngIf.
This directive will help us create cleaner code without manually subscriptions management in each component which uses ChangeDetectionStrategy.OnPush and NbLayoutDirectionService.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants