Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOTDB-1319] Trigger module: alert manager sink #3057

Merged
merged 15 commits into from Apr 28, 2021
Merged

Conversation

@mzp0514
Copy link
Contributor

@mzp0514 mzp0514 commented Apr 24, 2021

Description

Content1 ...

Content2 ...

Content3 ...


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR
@mzp0514 mzp0514 force-pushed the mzp0514:sink branch 2 times, most recently from ac188e6 to 3d0d451 Apr 24, 2021
@mzp0514 mzp0514 force-pushed the mzp0514:sink branch from 966cdca to 114a1d5 Apr 24, 2021
@SteveYurongSu
Copy link
Contributor

@SteveYurongSu SteveYurongSu commented Apr 26, 2021

Please rename this PR to:

[IOTDB-1319] Trigger module: alert manager sink

@mzp0514 mzp0514 changed the title Sink Trigger module: alert manager sink Apr 26, 2021
@mzp0514 mzp0514 changed the title Trigger module: alert manager sink [IOTDB-1319] Trigger module: alert manager sink Apr 26, 2021
@mzp0514 mzp0514 force-pushed the mzp0514:sink branch from bd453a7 to 7dcd9b5 Apr 26, 2021
@mzp0514 mzp0514 force-pushed the mzp0514:sink branch 6 times, most recently from 2b2d85e to db2141a Apr 26, 2021
@mzp0514 mzp0514 force-pushed the mzp0514:sink branch from 883f242 to a0e07e9 Apr 27, 2021
annotations.put("summary", "high temperature");
annotations.put("description", "{{.alertname}}: {{.series}} is {{.value}}");
}

This comment has been minimized.

@SteveYurongSu

SteveYurongSu Apr 27, 2021
Contributor

Should we override onStart() / onStop()?

This comment has been minimized.

@SteveYurongSu

SteveYurongSu Apr 27, 2021
Contributor

Can the client be reopened?

This comment has been minimized.

@mzp0514

mzp0514 Apr 28, 2021
Author Contributor

updated

@mzp0514 mzp0514 force-pushed the mzp0514:sink branch from 77fe88c to 6698f27 Apr 28, 2021
Copy link
Contributor

@SteveYurongSu SteveYurongSu left a comment

LGTM! Thanks for your contribution.

@LebronAl LebronAl merged commit a6401e4 into apache:master Apr 28, 2021
17 of 19 checks passed
17 of 19 checks passed
unix (8, ubuntu-latest) unix (8, ubuntu-latest)
Details
E2E (cli)
Details
unix (11, ubuntu-latest)
Details
greeting
Details
win (8, others)
Details
ubuntu
Details
unix (8, macos-latest)
Details
win (8, server)
Details
unix (11, ubuntu-latest) unix (11, ubuntu-latest)
Details
win (8, cluster)
Details
unix (11, macos-latest)
Details
win (11, others)
Details
unix (15, ubuntu-latest)
Details
win (11, server)
Details
unix (15, macos-latest)
Details
win (11, cluster)
Details
win (15, others)
Details
win (15, server)
Details
win (15, cluster)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants