This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Add types for tuple extraction instructions with map element read and channel receive bases#528
Merged
sauyon merged 9 commits intogithub:mainfrom Apr 21, 2021
Merged
Conversation
Specifically, extractions where the RHS is a map element read or a channel receive will now have types.
Contributor
|
@sauyon I pushed a few changes: simplifying the implementation, adding a test and copyediting a little. Merge and notify Luke if you're happy. |
smowton
approved these changes
Apr 21, 2021
owen-mc
reviewed
Apr 21, 2021
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com>
sauyon
commented
Apr 21, 2021
Contributor
Author
sauyon
left a comment
sauyon
left a comment
There was a problem hiding this comment.
That's much nicer, LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.