Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Termui] Markdown rendering #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Termui] Markdown rendering #165

wants to merge 1 commit into from

Conversation

MichaelMure
Copy link
Owner

@MichaelMure MichaelMure commented Jun 8, 2019

fix #12

termui/markdown/markdown.go Outdated Show resolved Hide resolved
termui/markdown/renderer.go Outdated Show resolved Hide resolved
@MichaelMure
Copy link
Owner Author

MichaelMure commented Nov 20, 2019

For the curious, this PR now lives in https://github.com/MichaelMure/go-term-markdown. Once completed, it will be imported here.

@MichaelMure MichaelMure requested a review from A-Hilaly Nov 25, 2019
@MichaelMure MichaelMure marked this pull request as ready for review Nov 25, 2019
Copy link
Collaborator

@A-Hilaly A-Hilaly left a comment

LGTM 🚢
Great work on github.com/MichaelMure/go-term-markdown 👍

@MichaelMure MichaelMure added this to the 0.7.0 milestone Dec 11, 2019
@MichaelMure MichaelMure modified the milestones: 0.7.0, 0.8.0 Feb 29, 2020
@6543
Copy link
Collaborator

6543 commented Aug 1, 2021

@MichaelMure should I try to rebase it for you?

@MichaelMure
Copy link
Owner Author

MichaelMure commented Aug 2, 2021

You could but a V2 of go-term-markdown kinda stalled over at MichaelMure/go-term-markdown#20

IIRC there is still some rendering problems but more importantly someone should make sure it's safe against abuse as it will be used to render arbitrary JSON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants