Skip to content

/ fast

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dedupe and update packages #4332

Merged
merged 7 commits into from Feb 6, 2021
Merged

chore: dedupe and update packages #4332

merged 7 commits into from Feb 6, 2021
+5,110 −10,106

Conversation

@radium-v
Copy link
Contributor

@radium-v radium-v commented Feb 4, 2021 •
edited

Description

  • Dedupe lodash-es, @babel/*, and typescript
  • Update docusaurus and storybook addons
  • Lock specific versions for api-extractor@7.8.1, lodash-es@4.7.15
  • Regenerate lockfile
  • Don't run build when running test

To test it locally, make sure to do a full clean with yarn lerna clean and git clean before running yarn install.

Motivation & context

Cuts dependencies down from >1GB to ~634MB.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.
@codeclimate
codeclimate bot reviewed Feb 4, 2021
View changes
Copy link

@codeclimate codeclimate bot left a comment

The PR diff size of 15248 lines exceeds the maximum allowed for the inline comments feature.
@awentzel
awentzel reviewed Feb 4, 2021
View changes
examples/todo-app-tutorial/package.json
@@ -15,7 +15,7 @@
"@microsoft/fast-colors": "^5.0.12",
"@microsoft/fast-element": "latest",
"@microsoft/fast-foundation": "latest",
"lodash-es": "^4.17.15",
"lodash-es": "4.17.15",

This comment has been minimized.

Sign in to view
@awentzel

awentzel Feb 4, 2021
Member

@radium-v why are we pinning this version?

This comment has been minimized.

Sign in to view
@radium-v

radium-v Feb 4, 2021
Author Contributor

It's due to this bug (lodash/lodash#5033) in 4.17.20. Pretty much everything breaks with that latest version.

An alternative to pinning could be setting a top-level resolution entry, but I don't know how that will affect nested dependencies.
@nicholasrice
nicholasrice reviewed Feb 4, 2021
View changes
packages/tooling/fast-figma-plugin-msft/package.json Outdated
@@ -9,7 +9,7 @@
"watch": "webpack --progress --watch --mode=production",
"prettier": "prettier --config ../../../.prettierrc --write \"**/*.{ts,tsx}\"",
"prettier:diff": "prettier --config ../../../.prettierrc \"**/*.{ts,tsx}\" --list-different",
"test": "yarn eslint && yarn build",
"test": "yarn eslint",

This comment has been minimized.

Sign in to view
@nicholasrice

nicholasrice Feb 4, 2021 •
edited
Member

What's the rational for not building as part of the test pass? (question goes for all packages you've done this)

This comment has been minimized.

Sign in to view
@radium-v

radium-v Feb 4, 2021
Author Contributor

Building after testing is redundant in more situations than not. I'll move these specific changes to a different PR with more details.

This comment has been minimized.

Sign in to view
@radium-v

radium-v Feb 4, 2021
Author Contributor

#4336
@radium-v radium-v force-pushed the users/jokreitl/modules-dedupe branch from 4ac9165 to f5f5481 Feb 4, 2021
@codeclimate
codeclimate bot reviewed Feb 4, 2021
View changes
Copy link

@codeclimate codeclimate bot left a comment

The PR diff size of 15226 lines exceeds the maximum allowed for the inline comments feature.
@nicholasrice
nicholasrice reviewed Feb 4, 2021
View changes
packages/utilities/fast-web-utilities/package.json Outdated Show resolved Hide resolved
@nicholasrice
nicholasrice approved these changes Feb 5, 2021
View changes
@nicholasrice nicholasrice self-requested a review Feb 5, 2021
radium-v added 6 commits Feb 5, 2021
@radium-v
dedupe lodash
1f83978
@radium-v
dedupe babel
45c462a
@radium-v
Update api-extractor dependencies
7bcb600
@radium-v
update docusaurus and storybook dependencies
2976ff2
@radium-v
dedupe typescript
7cf715e
@radium-v
regenerate lockfile and switch from .babelrc to babel.config.js
Loading status checks…
fe59ac9
@radium-v radium-v force-pushed the users/jokreitl/modules-dedupe branch from f5f5481 to fe59ac9 Feb 5, 2021
@codeclimate
codeclimate bot reviewed Feb 5, 2021
View changes
Copy link

@codeclimate codeclimate bot left a comment

The PR diff size of 15216 lines exceeds the maximum allowed for the inline comments feature.
@nicholasrice
nicholasrice approved these changes Feb 5, 2021
View changes
Copy link
Member

@nicholasrice nicholasrice left a comment

I'm super excited for this!
@chrisdholt
Merge branch 'master' into users/jokreitl/modules-dedupe
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
db9b217
@chrisdholt
chrisdholt approved these changes Feb 5, 2021
View changes
@codeclimate
codeclimate bot reviewed Feb 5, 2021
View changes
Copy link

@codeclimate codeclimate bot left a comment

The PR diff size of 15216 lines exceeds the maximum allowed for the inline comments feature.
@codeclimate
Copy link

@codeclimate codeclimate bot commented Feb 5, 2021

Code Climate has analyzed commit db9b217 and detected 0 issues on this pull request.

View more on Code Climate.
@chrisdholt chrisdholt merged commit 5643033 into master Feb 6, 2021
3 checks passed
3 checks passed
build_linux
Details
codeclimate All good!
Details
license/cla All CLA requirements met.
Details
@chrisdholt chrisdholt deleted the users/jokreitl/modules-dedupe branch Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awentzel awentzel

@codeclimate codeclimate

@nicholasrice nicholasrice

@chrisdholt chrisdholt

@bheston bheston

@EisenbergEffect EisenbergEffect

@Falkicon Falkicon

@janechu janechu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@radium-v @nicholasrice @chrisdholt @awentzel