build: avoid installing node-sass #22283
Merged
+31
−201
Conversation
We no longer use `node-sass`, but we were still installing it, because `gulp-sass` depends upon it. These changes switch to a fork of `gulp-sass` that depends on the Dart version of Sass.
|
LGTM |
|
It looks like https://www.npmjs.com/package/gulp-dart-sass is getting some good usage and installation growth, but it's too bad that the repo hasn't been updated since October and doesn't accept issues (only PRs). It's good to get off of node-sass for sure, but it isn't clear that this new package will be something that we can rely upon long-term. |
|
Needs rebase to get it into 11.2.x |
andrewseguin
merged commit 902e946
into
angular:master
16 checks passed
16 checks passed
ci/angular: merge status
All checks passed!
cla/google
All necessary CLAs are signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
We no longer use
node-sass, but we were still installing it, becausegulp-sassdepends upon it. These changes switch to a fork ofgulp-sassthat depends on the Dart version of Sass.