Skip to content

/ deno

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"deno upgrade" downloads the `x86_64` binary release on aarch64 #5369

Open
06kellyjac opened this issue May 14, 2020 · 3 comments
Open

"deno upgrade" downloads the `x86_64` binary release on aarch64 #5369

06kellyjac opened this issue May 14, 2020 · 3 comments
Labels
bug good first issue

Comments

@06kellyjac
Copy link
Contributor

@06kellyjac 06kellyjac commented May 14, 2020

Until aarch64 releases are vendored (#4862), deno upgrade should exit with an error message rather than downloading, unzipping, and trying to execute an x86_64 binary on an aarch64 system.
@06kellyjac 06kellyjac mentioned this issue May 14, 2020
Closed
@ry
Copy link
Member

@ry ry commented May 14, 2020

I agree and should be an easy fix
@06kellyjac
Copy link
Contributor Author

@06kellyjac 06kellyjac commented May 14, 2020

Error log:

> ./target/debug/deno upgrade -f --dry-run -L debug
Checking for latest version
starting new connection: https://github.com/
resolving host="github.com"
...
Version has been found
Deno is upgrading to version 1.0.0
downloading https://github.com/denoland/deno/releases/download/v1.0.0/deno-x86_64-unknown-linux-gnu.zip
...
incoming body completed
pooling idle connection for ("https", github-production-release-asset-2e65be.s3.amazonaws.com)
Archive:  /run/user/1000/.tmp0Ap59Q/deno.zip
  inflating: deno
error: Exec format error (os error 8)

> file /run/user/1000/.tmp0Ap59Q/deno
/run/user/1000/.tmp0Ap59Q/deno: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.6.32, BuildID[sha1]=b914ea3fdbf0a4300975e7f314d7e7d8d7f44c2a, with debug_info, not stripped

> uname -mo
aarch64 GNU/Linux
@06kellyjac
Copy link
Contributor Author

@06kellyjac 06kellyjac commented May 14, 2020

Forked deno, starting work on the fix
@06kellyjac 06kellyjac mentioned this issue May 14, 2020
Closed
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

upgrade only binary releases
2 participants
@ry @06kellyjac
You can’t perform that action at this time.