feat(testing): add tests for serviceWorker.ts #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
reviewed
Feb 18, 2021
oxy
approved these changes
Feb 22, 2021
LGTM! Your call on the ; in one of the patches we apply; I think internal consistency with the patched file may be the best.
code-asher
reviewed
Feb 22, 2021
jsjoeio
force-pushed
the
add-tests-register
branch
3 times, most recently
from
14ad29a
to
909d425
|
EDIT: this time it was a network timeout. Running again.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR adds a few tests for
src/browser/serviceWorker.ts.Screenshot
It increases our code coverage (Lines) from 51.31% to 51.74% (↑ 0.43%).
🟩 100% Line coverage (last 100) for
src/browser/serviceWorker.tsThis also completes Lines coverage for🎉
src/browserTODOS
The text was updated successfully, but these errors were encountered: