Skip to content

/ angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to rulesnodejs@3.1.0 #40710

Closed
wants to merge 17 commits into from
Closed

Update to rulesnodejs@3.1.0 #40710

wants to merge 17 commits into from
+454 −415

Conversation

@josephperrott
Copy link
Member

@josephperrott josephperrott commented Feb 4, 2021 •
edited

See individual commits.

See rules_nodejs#stricter-ts-typechecks for more information on changes to castings involving JSON.parse
@ngbot ngbot bot modified the milestone: Backlog Feb 4, 2021
@google-cla google-cla bot added the cla: yes label Feb 4, 2021
@josephperrott josephperrott marked this pull request as ready for review Feb 5, 2021
@AndrewKushnir
AndrewKushnir reviewed Feb 5, 2021
View changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

@josephperrott could you plz share a link (may be add to a PR description) to a change that triggered JSON.parse type cast (as an additional context for CR)?
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(localize): update type castings for JSON.parse usage (#40710)
Loading status checks…
57d46d4 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(elements): update type castings for JSON.parse usage (#40710)
Loading status checks…
cd1b764 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(compiler-cli): update type castings for JSON.parse usage (#40710)
Loading status checks…
bc7be8f 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(compiler): update type castings for JSON.parse usage (#40710)
Loading status checks…
ceafef1 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(benchpress): update type castings for JSON.parse usage (#40710)
Loading status checks…
52da337 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(bazel): update type castings for JSON.parse usage (#40710)
Loading status checks…
36a3a6a 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(dev-infra): update type castings for JSON.parse usage (#40710)
Loading status checks…
305d41c 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(bazel): update build tooling for latest changes in rules_nodejs (#…
Loading status checks…
621c32d 
…40710)

Update the build tooling to handle the changes in the latest version of rules_nodejs.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(dev-infra): update build tooling for latest changes in rules_node…
Loading status checks…
1e06407 
…js (#40710)

Update the build tooling to handle the changes in the latest version of rules_nodejs.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(compiler-cli): update ngcc integration tests for latest changes i…
Loading status checks…
a4e396d 
…n rules_nodejs (#40710)

Update the ngcc integration tests to handle the changes in the latest version of rules_nodejs.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
build: update to rules_nodejs@3.1.0 (#40710)
53adebd 
Update to the latest version of rules_nodejs.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(bazel): update integration test to use rules_nodejs@3.1.0 (#40710)
a3e556f 
Update the integraiton tests for bazel to the latest rules_nodejs version.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
build: update tools directory for latest changes in rules_nodejs (#40710
75b3f9f 
)

Update the scripts/tooling in the tools directory to handle the changes in the latest
version of rules_nodejs.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(zone.js): update build tooling for latest changes in rules_nodejs (…
b02136a 
…#40710)

Update the zone.js build tooling to handle the changes in the latest version of rules_nodejs.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(service-worker): update type castings for JSON.parse usage (#40710)
62845f3 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(router): update type castings for JSON.parse usage (#40710)
456a991 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(platform-browser): update type castings for JSON.parse usage (#40710
3320373 
)

Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(localize): update type castings for JSON.parse usage (#40710)
4661d90 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(elements): update type castings for JSON.parse usage (#40710)
547f8a0 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(compiler-cli): update type castings for JSON.parse usage (#40710)
72c2f06 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(compiler): update type castings for JSON.parse usage (#40710)
9e786f9 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(benchpress): update type castings for JSON.parse usage (#40710)
020a576 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(bazel): update type castings for JSON.parse usage (#40710)
dc9c50d 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(dev-infra): update type castings for JSON.parse usage (#40710)
ddf12e4 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(bazel): update build tooling for latest changes in rules_nodejs (#…
7e1eac3 
…40710)

Update the build tooling to handle the changes in the latest version of rules_nodejs.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(dev-infra): update build tooling for latest changes in rules_node…
d568a8d 
…js (#40710)

Update the build tooling to handle the changes in the latest version of rules_nodejs.

PR Close #40710
alxhub added a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(compiler-cli): update ngcc integration tests for latest changes i…
Loading status checks…
3c0846a 
…n rules_nodejs (#40710)

Update the ngcc integration tests to handle the changes in the latest version of rules_nodejs.

PR Close #40710
@josephperrott josephperrott deleted the josephperrott:update-rulesnodejs-3.1.0 branch Feb 9, 2021
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Mar 12, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4

@AndrewKushnir AndrewKushnir

@petebacondarwin petebacondarwin

@IgorMinar IgorMinar

Assignees
No one assigned
Labels
action: merge action: merge-assistance cla: yes comp: bazel comp: benchpress comp: build & ci comp: compiler comp: dev-infra comp: elements comp: i18n comp: router comp: service-worker comp: testing comp: ts-api-guardian comp: zones target: patch
Projects
None yet
Milestone
Backlog
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@josephperrott @alan-agius4 @petebacondarwin @IgorMinar @AndrewKushnir