Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add notices to move to new repo #220

Merged
merged 4 commits into from Nov 16, 2020
Merged

chore: add notices to move to new repo #220

merged 4 commits into from Nov 16, 2020

Conversation

@bharathkkb
Copy link
Collaborator

@bharathkkb bharathkkb commented Oct 30, 2020

  • Adds notices in source code and readme to inform users of upcoming repo changes

TODO:

  • individual action repos
@bharathkkb bharathkkb requested a review from averikitsch Oct 30, 2020
appengine-deploy/src/main.ts Outdated Show resolved Hide resolved
@google-cla google-cla bot added cla: no and removed cla: yes labels Nov 14, 2020
@bharathkkb bharathkkb force-pushed the notice-for-new-repo branch from 69001f0 to a116029 Nov 14, 2020
@bharathkkb bharathkkb force-pushed the notice-for-new-repo branch from 858c288 to ef08a55 Nov 14, 2020
@google-github-actions google-github-actions deleted a comment from google-cla bot Nov 14, 2020
@google-cla
Copy link

@google-cla google-cla bot commented Nov 14, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

@googlebot googlebot commented Nov 14, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-github-actions google-github-actions deleted a comment from google-cla bot Nov 14, 2020
@bharathkkb
Copy link
Collaborator Author

@bharathkkb bharathkkb commented Nov 14, 2020

New changes include

  • regenerated dists for all repos with notices
  • I realized that the initial approach wont work for setup-gcloud as we have not top leveled setup-gcloud action yet.

We can either top level setup-gcloud action to / now and freeze code inside /setup-gcloud or what I have currently done is:

  • generated a dist-frozen which has deprecation notice and then removed it from src here 2dfd1c5
  • targeted setup-gcloud/action.yml to point at dist-frozen/index.js so that anyone using GoogleCloudPlatform/github-actions/setup-gcloud will get the core.info notice.
  • targeted all setup-gcloud IT to use /action.yml which points to /setup-gcloud/dist/index.js in 96bcc68 which does not have the notice
  • users who reference the newgoogle-github-actions/setup-gcloud will use the /action.yml which inturn will use the /setup-gcloud/dist/index.js
  • long term when we are ready to delete old actions, all we will need to do is target /action.yml to point to /dist/index.js instead of /setup-gcloud/dist/index.js

I think top leveling might be easier but it may look messy as we have to maintain the 6 other action directories for a while.

@bharathkkb bharathkkb requested a review from averikitsch Nov 14, 2020
@bharathkkb bharathkkb marked this pull request as draft Nov 16, 2020
@bharathkkb bharathkkb marked this pull request as ready for review Nov 16, 2020
@bharathkkb bharathkkb merged commit b94035a into master Nov 16, 2020
49 checks passed
49 checks passed
appengine-deploy (ubuntu-latest)
Details
with setup-gcloud with setup-gcloud
Details
test (ubuntu-latest)
Details
test (ubuntu-latest)
Details
test (ubuntu-latest)
Details
test (ubuntu-latest)
Details
setup-gcloud versioned (ubuntu-latest)
Details
setup-gcloud (ubuntu-latest) setup-gcloud (ubuntu-latest)
Details
setup-gcloud (ubuntu-latest) setup-gcloud (ubuntu-latest)
Details
setup-gcloud-sdk (ubuntu-latest)
Details
setup-gcloud-sdk (ubuntu-latest)
Details
test (ubuntu-latest)
Details
appengine-deploy (windows-latest)
Details
test (windows-latest)
Details
test (windows-latest)
Details
test (windows-latest)
Details
test (windows-latest)
Details
setup-gcloud versioned (windows-latest)
Details
setup-gcloud (windows-latest) setup-gcloud (windows-latest)
Details
setup-gcloud (windows-latest) setup-gcloud (windows-latest)
Details
setup-gcloud-sdk (windows-latest)
Details
setup-gcloud-sdk (windows-latest)
Details
test (windows-latest)
Details
appengine-deploy (macos-latest)
Details
test (macos-latest)
Details
test (macos-latest)
Details
test (macos-latest)
Details
test (macos-latest)
Details
setup-gcloud versioned (macos-latest)
Details
setup-gcloud (macos-latest) setup-gcloud (macos-latest)
Details
setup-gcloud (macos-latest) setup-gcloud (macos-latest)
Details
setup-gcloud-sdk (macos-latest)
Details
setup-gcloud-sdk (macos-latest)
Details
test (macos-latest)
Details
with base64 json creds with base64 json creds
Details
setup-gcloud latest (ubuntu-latest)
Details
setup-gcloud latest (windows-latest)
Details
setup-gcloud latest (macos-latest)
Details
with json creds with json creds
Details
setup-gcloud user-defined email (ubuntu-latest)
Details
setup-gcloud user-defined email (windows-latest)
Details
setup-gcloud user-defined email (macos-latest)
Details
setup-gcloud exported credentials (ubuntu-latest)
Details
setup-gcloud exported credentials (windows-latest)
Details
setup-gcloud exported credentials (macos-latest)
Details
setup-gcloud with configured project (ubuntu-latest)
Details
setup-gcloud with configured project (windows-latest)
Details
setup-gcloud with configured project (macos-latest)
Details
cla/google All necessary CLAs are signed
@bharathkkb bharathkkb deleted the notice-for-new-repo branch Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.