Ensure sync-xhr is allowed before reload and profile #20879
Merged
+58
−9
Conversation
|
Comparing: 9209c30...2310a7d Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
...ct-devtools-shared/src/devtools/views/Profiler/ReloadAndProfileButton.js
Outdated
Show resolved
Hide resolved
|
Hm. Why is Flow upset... Edit Weird. I'm using GitHub's inline editor to make changes and it looks like it screwed up a change to |
GitHub's inline editor seems to have messed up the previous inline edit.
We're no longer emitting an event for that.
|
Sorry for the noise. I should have just made my edits locally instead of using GH for it. Seemed easier at first but ended up being more work. Thanks for doing this! |
bvaughn
changed the title
bvaughn
merged commit bd245c1
into
facebook:master
35 checks passed
35 checks passed
ci/circleci: yarn_test--r=stable --env=development --persistent
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=development --variant
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=production --variant
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-modern --env=development --variant
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-modern --env=production --variant
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build---project=devtools -r=experimental
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build--r=experimental --env=development
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build--r=experimental --env=production
Your tests passed on CircleCI!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Summary
Fixes #20806
If
document.featurePolicy.allowsFeature('sync-xhr')returns false a message is displayed when the user first clicks the 'reload and profile' button and the button is then disabled.Test Plan
Screen.Recording.2021-02-25.at.10.09.59.mp4