This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Conversation
smowton
approved these changes
Jan 19, 2021
Contributor
smowton
left a comment
smowton
left a comment
There was a problem hiding this comment.
Looks good! How are the results / CVE hits?
|
|
||
| override predicate isSink(DataFlow::Node sink) { this.isSink(sink, _) } | ||
|
|
||
| predicate isSink(DataFlow::Node sink, string kind) { kind = sink.(Sink).getKind() } |
|
|
||
| override predicate isSink(DataFlow::Node sink) { this.isSink(sink, _) } | ||
|
|
||
| predicate isSink(DataFlow::Node sink, string kind) { kind = sink.(Sink).getKind() } |
Contributor
There was a problem hiding this comment.
Suggested change
| predicate isSink(DataFlow::Node sink, string kind) { kind = sink.(Sink).getKind() } | |
| predicate isSink(Sink sink, string kind) { kind = sink.getKind() } |
|
|
||
| predicate isSink(DataFlow::Node sink, string kind) { kind = sink.(Sink).getKind() } | ||
|
|
||
| override predicate isSanitizer(DataFlow::Node node) { none() } |
Contributor
There was a problem hiding this comment.
This is already the default
| from Configuration cfg, DataFlow::PathNode source, DataFlow::PathNode sink, string kind | ||
| where cfg.hasFlowPath(source, sink) and cfg.isSink(sink.getNode(), kind) | ||
| select sink.getNode(), source, sink, | ||
| "$@ is a value generated with a cryptographically weak RNG used in $@.", source.getNode(), |
Contributor
There was a problem hiding this comment.
Suggested change
| "$@ is a value generated with a cryptographically weak RNG used in $@.", source.getNode(), | |
| "$@ is generated with a cryptographically weak RNG used in $@.", source.getNode(), |
Comment on lines
18
to
19
| "$@ is a value generated with a cryptographically weak RNG used in $@.", source.getNode(), | ||
| "Random number", sink.getNode(), kind |
Contributor
There was a problem hiding this comment.
Suggested change
| "$@ is a value generated with a cryptographically weak RNG used in $@.", source.getNode(), | |
| "Random number", sink.getNode(), kind | |
| "$@ is generated with a cryptographically weak RNG used in $@.", source.getNode(), | |
| "A random number", sink.getNode(), kind |
Contributor
Author
There was a problem hiding this comment.
I assume you want "A random number generated with a cryptographically weak RNG is used in "?
Contributor
There was a problem hiding this comment.
I was aiming at "is generated", but that's better
shati-patel
approved these changes
Jan 20, 2021
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Just a few tiny comments, otherwise LGTM 😃
sauyon
force-pushed
the
insecure-rng
branch
2 times, most recently
from
9ef8d4e to
3d0b09f
Compare
owen-mc
approved these changes
Jan 21, 2021
added 2 commits
February 2, 2021 08:04
Also give it a precision
sauyon
force-pushed
the
insecure-rng
branch
2 times, most recently
from
bd33cf7 to
511a143
Compare
Contributor
Author
|
The newest commit needs review, I think. I accidentally ran the dist-compare on the old version of this, so that's running again, huzzah. |
smowton
approved these changes
Feb 4, 2021
Contributor
smowton
left a comment
smowton
left a comment
There was a problem hiding this comment.
Restriction to first match seems ok to me, one possible cleanup
| kind != "a password-related function" | ||
| or | ||
| sink = | ||
| rank[1](DataFlow::PathNode sink2, int line | |
Contributor
There was a problem hiding this comment.
rank[1] can become min I think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note I moved the
WeakCryptoAlgorithmtests along with the insecure randomness ones because they share code.