Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a Github pages repo as private will not work even after changing visibility #2418

Closed
chrislgarry opened this issue Dec 29, 2020 · 11 comments · Fixed by #3262
Closed

Creating a Github pages repo as private will not work even after changing visibility #2418

chrislgarry opened this issue Dec 29, 2020 · 11 comments · Fixed by #3262
Assignees
Labels
content core

Comments

@chrislgarry
Copy link

@chrislgarry chrislgarry commented Dec 29, 2020

I made a website following the Github pages documentation, but accidentally made the repository private upon creation. Changing it to public afterwards, my webpage was still not visible. Documentation I've found states the repository must be public if you you're not a Pro user, however it doesn't mention it must be public upon creation time. My fix was to delete the repository and recreate it with public visibility upon creation. Something in the documentation stating this edge case would be helpful. I suspect changing visibility after the fact does not initiate DNS, hosting, etc.

@welcome
Copy link

@welcome welcome bot commented Dec 29, 2020

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage label Dec 29, 2020
@github-actions github-actions bot added this to Triage in Docs open source board Dec 29, 2020
@chrislgarry
Copy link
Author

@chrislgarry chrislgarry commented Dec 29, 2020

If there is a particular place to fix and make a PR, I'm happy to do so. Thanks!

@janiceilene
Copy link
Collaborator

@janiceilene janiceilene commented Dec 29, 2020

@chrislgarry Thanks so much for opening an issue! I'll triage this for the team to take a look at and figure out the best course of action 👀

@janiceilene janiceilene moved this from Triage to Anyone in Docs open source board Dec 29, 2020
@janiceilene janiceilene added content core and removed triage labels Dec 29, 2020
@chrislgarry
Copy link
Author

@chrislgarry chrislgarry commented Dec 30, 2020

@janiceilene thank you! Apologies for the lack of actionable data (logs, specific code responsible, etc.). Didnt have much time to chase it down. Hopefully it's pretty straightforward 🙆‍♂️

@jihnny540

This comment has been minimized.

@felicitymay felicitymay self-assigned this Jan 19, 2021
@felicitymay
Copy link
Contributor

@felicitymay felicitymay commented Jan 19, 2021

Hi @chrislgarry - many thanks for flagging this unexpected behavior. I'll check with the pages team on this and then we can work out the best way to document this limitation.

@felicitymay
Copy link
Contributor

@felicitymay felicitymay commented Jan 19, 2021

The pages team have got back to me with the following explanation:

This is expected and the user could have enabled pages once the repository was made public by selecting a source branch for Pages in their repository settings. We enable Pages automatically only on push. Not on any other events (such as repository switches from private to public for instance).

It sounds as if https://pages.github.com/ could do with a link out to a troubleshooting guide at the end to give tips like this. The content on that page is maintained in a different repository, so I'll forward your feedback on to the relevant team.

I was looking at the https://docs.github.com site (which is published to from the docs repository) to see if this was explained here. Possibly it would be worth updating step 4 of Creating a repository for your site and Creating a repository for your site (Jekyll) to recommend that this is a public site, since GitHub Pages are displayed publicly. As well as avoiding GitHub Free users encountering your problem, it might also help other users reduce the chance of accidentally publishing private information to a public pages site.

@felicitymay
Copy link
Contributor

@felicitymay felicitymay commented Jan 28, 2021

I've raised #3262 to make the information about this on docs.github.com clearer.

@felicitymay
Copy link
Contributor

@felicitymay felicitymay commented Jan 28, 2021

I'll raise an internal issue with the relevant team to ask them to amend https://pages.github.com/ so that this is clearer too.

@felicitymay
Copy link
Contributor

@felicitymay felicitymay commented Jan 28, 2021

😁 https://pages.github.com/ now updated to suggest creating a public repository.

Docs open source board automation moved this from Anyone to Done Feb 2, 2021
@chrislgarry
Copy link
Author

@chrislgarry chrislgarry commented Feb 2, 2021

@felicitymay @janiceilene thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content core
Development

Successfully merging a pull request may close this issue.

5 participants
@felicitymay @chrislgarry @janiceilene @jihnny540 and others