Skip to content

/ xterm.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling `XTerm.fit` with a non-visable terminal results in thrown error #3118

Open
Nokel81 opened this issue Sep 30, 2020 · 1 comment
Open

Calling `XTerm.fit` with a non-visable terminal results in thrown error #3118

Nokel81 opened this issue Sep 30, 2020 · 1 comment
Labels
good first issue help wanted type/bug

Comments

@Nokel81
Copy link

@Nokel81 Nokel81 commented Sep 30, 2020

Details

  • Electron: 9.1.2
  • Chrome: 83.0.4103.122
  • OS version: macos 10.15
  • xterm.js version: 4.9.0

Steps to reproduce

  1. Have the terminal not being rendered
  2. Using the FitAddon call fit()
  3. Observe the This API only accepts integers error.

Seems like this has regressed from #525 but that was over 3 years ago (with at least one major refactor) so I couldn't find when this happened.
@Tyriar
Copy link
Member

@Tyriar Tyriar commented Nov 4, 2020 •
edited

The API is a little more strict now and will throw invalid values instead of silently failing.

This is kind of by design, but we could either throw a more descriptive error instead of passing invalid values to Terminal.resize, or alternatively just not doing anything.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted type/bug
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@Tyriar @jerch @Nokel81
You can’t perform that action at this time.