ronag
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
8,835 contributions in the last year
Activity overview
Contribution activity
October 2020
Created a pull request in nodejs/node that received 6 comments
stream: async iterator stop read if destroyed
Fixes some compatibility issues where it is expected
that for await stops reading when the stream is
destroyed.
Refs: #34887 Checklist
make -j4 test
+1
−3
•
6
comments
- stream: fix async iterator not reading last chunk on close
- doc: fix _construct example params order
- lib: fix duplicate logic in stream destroy
- lib: fix stream as context is redundant
- stream: async iterator stop read if destroyed
- [v14.x backport] stream: simpler and faster Readable async iterator
- doc: document Buffer.concat may use internal pool
- stream: writableNeedDrain
- test: do not use the same EventEmitter instance
- [v12.x backport] stream: destroy wrapped streams on error
- fs: add validation for fd and path
Created an issue in nodejs/undici that received 14 comments
Don't timeout if socket is paused?
This is a bit different than how it works in node but I think it would make sense to not error if we have a socket timeout while the socket is paus…
14
comments
156
contributions
in private repositories
Oct 1 – Oct 16