fix: fix unit test script #4741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue with the unit test script where it could not be run without Mocha installed globally since there was a bug where the alias wasn't working, but if Mocha was installed globally, it would use that instance to run the tests. However, if Mocha is not installed globally, then it would fail because it pointed to the local instance of Mocha using a relative path that was in direct conflict with the relative path used to run the local instance of pm2. The npx command fixes these issues by finding the local instance of a npm binary regardless of what the current directory is.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This commit fixes an issue with the unit test script where it
could not be run without Mocha installed globally since there was
a bug where the alias wasn't working, but if Mocha was installed
globally, it would use that instance to run the tests. However, if
Mocha is not installed globally, then it would fail because it
pointed to the local instance of Mocha using a relative path that
was in direct conflict with the relative path used to run the local
instance of pm2. The npx command fixes these issues by finding the
local instance of a npm binary regardless of what the current
directory is.