Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add workspaces hash to yarn cache key #20154
Conversation
|
Would we also hit this caching problem on the same branch if we added new deps? |
|
If we add new deps, the yarn.lock checksum should change and break the cache |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2d4ebb5:
|
|
I believe that the issue here is that we changed the workspace, which requires a yarn install, but we didn't change the yarn.lock so when the PR was merged we used the cache node_modules and didn't run yarn. If that's the case, then this PR won't solve the issue. Looking into a real fix now. |
|
Did not read. |
rickhanlonii
changed the title
rickhanlonii
merged commit 6b28eb6
into
facebook:master
This should hopefully fix the tests on the main branch.