Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
2,012 contributions in the last year
Contribution activity
October 2020
- nornagon/docs-parser TypeScript
Created a pull request in electron/electron that received 8 comments
test: deflake ses.setProxy test
Description of Change Example flake: https://app.circleci.com/pipelines/github/electron/electron/31724/workflows/ad370a6d-7c65-44dc-bf8b-e3978e263f…
- chore: don't self-include inspectable_web_contents.h
- chore: cherry-pick 9591642a0896 from pdfium
- chore: cherry-pick 9591642a0896 from pdfium
- chore: cherry-pick 9591642a0896 from pdfium
- chore: cherry-pick f440137cd96a from chromium
- chore: cherry-pick f440137cd96a from chromium
- chore: cherry-pick f440137cd96a from chromium
- chore: cherry-pick 6a4cd97d6691 from v8
- chore: cherry-pick 6a4cd97d6691 from v8
- chore: cherry-pick 6a4cd97d6691 from v8
- chore: cherry-pick 30261f9de11e from chromium
- chore: cherry-pick 30261f9de11e from chromium
- chore: cherry-pick 30261f9de11e from chromium
- chore: cherry-pick 6aa1e71fbd09 from v8
- chore: cherry-pick 6aa1e71fbd09 from v8
- chore: cherry-pick 6aa1e71fbd09 from v8
- chore: cherry-pick 88f263f401b4 from chromium
- chore: cherry-pick 88f263f401b4 from chromium
- chore: cherry-pick 88f263f401b4 from chromium
- chore: cherry-pick 229fdaf8fc05 from chromium
- chore: cherry-pick 229fdaf8fc05 from chromium
- chore: cherry-pick 229fdaf8fc05 from chromium
- chore: cherry-pick 1ed869ad4bb3 from chromium
- chore: cherry-pick 1ed869ad4bb3 from chromium
- chore: cherry-pick 1ed869ad4bb3 from chromium
- Some pull requests not shown.
- build: auto-push patch file changes
- fix: transparently package bundles as zip archives
- feat: Added support for all proxy modes
- docs: clarify default value of enableRemoteModule
- feat: allow setting the Origin header and Sec-Fetch-* headers in net.request()
- chore: use consistent parameter names
- fix: Don't sort the headers of ClientRequest
- refactor: Chromium code style for enum classes
- refactor: remove x11 logic from filenames.gni
- perf: improve performance of heap snapshots.
- feat: add osProcessId / name properties to webFrameMain
- chore: use auto to avoid repeating type
- chore: bump chromium to 9b2191ea59cba1e2f6da4dbb7dee0 (master)
- chore: bump chromium to 87.0.4280.27 (11-x-y)
- fix: add Wayland support
- chore: prefer empty() check for readability
- fix: optimized asar paths checks
- build: fix running eslint on Windows
- chore: cherry-pick b977dff8 from freetype
- chore: cherry-pick b977dff8 from freetype
- chore: cherry-pick b977dff8 from freetype
- feat: add focus and blur events for WebContents
- build: use buffering when applying patches
- build: mtime cache for patches to speed up build
- refactor: use Map instead of Object for better semantics
- Some pull request reviews not shown.
Created an issue in electron/electron that received 4 comments
CHECK(CalledOnValidSequence()) - NativeImage crossing threads
I'm not sure what caused this but I saw this stack trace while running the renderer-side nativeImage tests. I wasn't able to reproduce it reliably.
[…
- Changes to the proxy config are not immediately reflected by resolveProxy at session creation time
- v8 CHECK() on shutdown in Event::~Event
- Crash on exit in extensions::ProcessManager::Shutdown
- Segfault in SerialChooserController
- Pretty-print JS in devtools doesn't work
- nativeImage.getBitmap() allows use-after-free