Skip to content

/ skaffold

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skaffold reloads unchanged, existing image again into the cluster #4955

Open
ErolPeel opened this issue Oct 27, 2020 · 3 comments
Open

Skaffold reloads unchanged, existing image again into the cluster #4955

ErolPeel opened this issue Oct 27, 2020 · 3 comments
Labels
good first issue kind/bug platform/k3d priority/p2

Comments

@ErolPeel
Copy link

@ErolPeel ErolPeel commented Oct 27, 2020

Expected behavior

Skaffold should not load already loaded image. In my case that's the image eu.gcr.io/tools-org-veroo/party-service:d46578239dd325395e15e8ab16a2c499616a15e662ed196c18549e8d2bea38b6.

Actual behavior

Skaffold does load image eu.gcr.io/tools-org-veroo/party-service:d46578239dd325395e15e8ab16a2c499616a15e662ed196c18549e8d2bea38b6 anew.

Information

  • Skaffold version: v1.15.0
  • operating system: macOS Catalina 10.15.7

I am loading two images into my k3d cluster.

This is the log output:

Checking cache...
 - eu.gcr.io/tools-org-veroo/party-service: Found Locally
 - eu.gcr.io/tools-org-veroo/party-service-flyway: Found Locally
Tags used in deployment:
 - eu.gcr.io/tools-org-veroo/party-service -> eu.gcr.io/tools-org-veroo/party-service:d46578239dd325395e15e8ab16a2c499616a15e662ed196c18549e8d2bea38b6
 - eu.gcr.io/tools-org-veroo/party-service-flyway -> eu.gcr.io/tools-org-veroo/party-service-flyway:65572b687b0f4a65e31fe7ef32545a4fa2902a05473701a5cc9dc45e2c707a69
Loading images into k3d cluster nodes...
 - eu.gcr.io/tools-org-veroo/party-service:d46578239dd325395e15e8ab16a2c499616a15e662ed196c18549e8d2bea38b6 -> Loaded
 - eu.gcr.io/tools-org-veroo/party-service-flyway:65572b687b0f4a65e31fe7ef32545a4fa2902a05473701a5cc9dc45e2c707a69 -> Found

However, both images are already in my cluster. So both images should have been found.

When I execute the command kubectl get nodes -o jsonpath='{@.items[*].status.images[*].names[*]}' I get this output:

eu.gcr.io/tools-org-veroo/party-service:d46578239dd325395e15e8ab16a2c499616a15e662ed196c18549e8d2bea38b6 eu.gcr.io/tools-org-veroo/party-service-flyway:65572b687b0f4a65e31fe7ef32545a4fa2902a05473701a5cc9dc45e2c707a69 docker.io/library/postgres@sha256:d26ddee3648a324a9747b3257236322141920d5f9a82ca703def6bff1cca7067 docker.io/library/postgres:alpine docker.io/rancher/klipper-helm@sha256:9cab2b9230d0454933de576b4e768cda8e0f1395cd5aca86ab649fc1d3be47bc docker.io/rancher/klipper-helm:v0.3.0 docker.io/rancher/library-traefik@sha256:3ba3ed48c4632f2b02671923950b30b5b7f1b556e559ce15446d1f5d648a037d docker.io/rancher/library-traefik:1.7.19 docker.io/rancher/coredns-coredns@sha256:e70c936deab8efed89db66f04847fec137dbb81d5b456e8068b6e71cb770f6c0 docker.io/rancher/coredns-coredns:1.6.9 docker.io/rancher/local-path-provisioner@sha256:40cb8c984c1759f1860eee088035040f47051c959a6d07cdb126e132c6f43b45 docker.io/rancher/local-path-provisioner:v0.0.14 docker.io/rancher/metrics-server@sha256:b85628b103169d7db52a32a48b46d8942accb7bde3709c0a4888a23d035f9f1e docker.io/rancher/metrics-server:v0.3.6 docker.io/rancher/klipper-lb@sha256:2fb97818f5d64096d635bc72501a6cb2c8b88d5d16bc031cf71b5b6460925e4a docker.io/rancher/klipper-lb:v0.1.2 docker.io/rancher/pause@sha256:d22591b61e9c2b52aecbf07106d5db313c4f178e404d660b32517b18fcbf0144 docker.io/rancher/pause:3.1

The image eu.gcr.io/tools-org-veroo/party-service:d46578239dd325395e15e8ab16a2c499616a15e662ed196c18549e8d2bea38b6 is also contained in this output.

Why is this image loaded anew into my cluster?
@tejal29
Copy link
Member

@tejal29 tejal29 commented Oct 27, 2020

@ErolPeel Skaffold does not check if an image is already present in the cluster.
You can add the command you mentioned above here https://github.com/GoogleContainerTools/skaffold/blob/master/pkg/skaffold/runner/load_images.go#L42

would you be up for the submitting a PR to do so?
@tejal29 tejal29 mentioned this issue Oct 28, 2020
Closed
@ErolPeel
Copy link
Author

@ErolPeel ErolPeel commented Oct 28, 2020 •
edited

@ErolPeel Skaffold does not check if an image is already present in the cluster.
You can add the command you mentioned above here https://github.com/GoogleContainerTools/skaffold/blob/master/pkg/skaffold/runner/load_images.go#L42

would you be up for the submitting a PR to do so?

As far as I can see, Skaffold checks, whether an image is already in the cluster or not:

skaffold/pkg/skaffold/runner/load_images.go

Line 87 in 5c9b6e7

func findKnownImages(ctx context.Context, cli *kubectl.CLI) ([]string, error) {

And as far as I can tell this function is called for both k3d and kind.
Or am I missing something?
@anshlykov anshlykov mentioned this issue Oct 31, 2020
Merged
@tejal29
Copy link
Member

@tejal29 tejal29 commented Nov 3, 2020

Or am I missing something?

you are correct. i didn't look further in the code :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue kind/bug platform/k3d priority/p2
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@tejal29 @ErolPeel
You can’t perform that action at this time.