Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmdlets have SupportsShouldProcess but don't actually implement it #279

Open
ThomasNieto opened this issue Oct 4, 2020 · 2 comments
Open

Cmdlets have SupportsShouldProcess but don't actually implement it #279

ThomasNieto opened this issue Oct 4, 2020 · 2 comments
Labels
bug
Projects
Milestone

Comments

@ThomasNieto
Copy link

@ThomasNieto ThomasNieto commented Oct 4, 2020

Cmdlets have SupportsShouldProcess but don't actually implement it for -WhatIf and -Confirm parameters. This gives users a false sense of security.

  • Install-PSResource
  • Publish-PSResource
  • Save-PSResource
  • Update-PSResource
  • Uninstall-PSResource
  • Register-PSResourceRepository
  • Unregister-PSResourceRepository
  • Set-PSResourceRepository

These don't need SupportsShouldProcess since they are non-state changing cmdlets.

  • Get-PSResourceRepository
  • Find-PSResource
  • Get-PSResource
@issue-label-bot issue-label-bot bot added the bug label Oct 4, 2020
@issue-label-bot
Copy link

@issue-label-bot issue-label-bot bot commented Oct 4, 2020

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.81. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@SydneyhSmith SydneyhSmith added this to the 3.0-Resolved milestone Oct 8, 2020
@SydneyhSmith
Copy link
Collaborator

@SydneyhSmith SydneyhSmith commented Oct 8, 2020

Thanks @ThomasNieto for calling this out, we do plan to implement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Preview 12
Awaiting triage
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.