Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Focusable elements are not focused making it difficult to know what you're interacting with #4298
Comments
|
As mentioned in the thread in the community, I think a great first step would be to make all hover states also apply on focus, that should get us pretty far already (and also improve the mobile experience!). If anybody wants to tackle that, a quick search for ":hover" in |
|
Can I work on this? |
|
Yes please @reddysridhar53! |
|
@mxstbr Can you help in understanding what is our final goal here? Having focus state for all actionable items or Accessibility ? |
|
Both! |
|
May I take this? |
|
It'd be great if you split the work with @reddysridhar53! |
|
Happy to review this work folks :) @mxstbr if this goes well and we plan for more work like this, is there a way to compensate the people doing the work? Like with open collective etc |
|
Hi @mxstbr , I was looking around for suitable suits to implement this and found https://github.com/WICG/focus-visible to be good. What do you think of us using this in the application? |
|
Hey @reddysridhar53 would you mind spitting the work between both of us or you rather tackle it alone ? |
|
Yeah that sounds reasonable! |
|
Good question @nickcolley! There currently aren't plans to compensate contributors. I know accessibility is certainly undervalued in the industry and while we'd like to be part of the solution, it's just not something we're prepared to tackle at the moment... |
|
@dantesolis we can split the work. I already started on focus-visible, would you be taking up the Accessibility? |
|
@reddysridhar53 I can take accessibility |
|
Hey guys! Has there been any update on this? |
Issue Type (check one)
Description (type any text below) -->
When tabbing through the Spectrum interface it's difficult to know what you're interacting with since the outlines for tabbable elements have been removed.
If you force outlines back on you can see what is being tabbed.
You might want to consider https://github.com/WICG/focus-visible if you're worried about having too many focus outlines in your interface.