Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to session management #757

Open
flybayer opened this issue Jul 16, 2020 · 6 comments
Open

Add unit tests to session management #757

flybayer opened this issue Jul 16, 2020 · 6 comments

Comments

@flybayer
Copy link
Collaborator

@flybayer flybayer commented Jul 16, 2020

What do you want and why?

We need to add comprehensive unit tests to our session management.

Feel free to submit PRs for single or few tests. And feel free to ask clarification questions.

Files:

@blitzjs-bot blitzjs-bot bot added this to Triage in Dashboard Jul 16, 2020
@blitzjs-bot blitzjs-bot bot added the status/triage label Jul 16, 2020
@blitzjs-bot blitzjs-bot bot moved this from Triage to Ready to Work On in Dashboard Jul 16, 2020
@cbadger85
Copy link

@cbadger85 cbadger85 commented Jul 18, 2020

I'd like to try and tackle this issue! I haven't contributed to open source before, but I'm pretty handy with jest.

@flybayer
Copy link
Collaborator Author

@flybayer flybayer commented Jul 18, 2020

@cbadger85 that'd be awesome! Here's our contributing docs. And here's a great free egghead video on the basics of open source like forking, submitting a PR, etc: https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github

Let me know if you have any questions!

@geeklisted
Copy link

@geeklisted geeklisted commented Oct 6, 2020

Is this issue still ready to work? Seems there have been a couple of merges.

@flybayer
Copy link
Collaborator Author

@flybayer flybayer commented Oct 6, 2020

@geeklisted yeah, still plenty to tests to add! :)

@clgeoio clgeoio mentioned this issue Oct 6, 2020
1 of 2 tasks complete
@geeklisted
Copy link

@geeklisted geeklisted commented Oct 6, 2020

I hope to try and contribute some tests over the course of the week. Excited to see a project heading back to the good ole' days of Web development.

@clgeoio
Copy link
Collaborator

@clgeoio clgeoio commented Oct 7, 2020

@geeklisted, I am probably going to get stuck in to the server/supertokens file soon. We should coordinate our efforts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dashboard
Ready to Work On
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.