Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to manuals #764

Merged
merged 3 commits into from Sep 7, 2020
Merged

Add links to manuals #764

merged 3 commits into from Sep 7, 2020

Conversation

@brianamarie
Copy link
Contributor

@brianamarie brianamarie commented Aug 17, 2020

Overview

TL;DR

We are open sourcing the training manuals. This PR adds links to those manuals, so that the training-kit landing page is a resource for finding other learning content in addition to cheat sheets.

Questions

<If relevant, write a list of questions that you would like to discuss related to the changes that you have made.>
N/A

Next Steps

<If incomplete, create a task list of items that are still being worked on within the Pull Request.>

As we move the training manual for developers into the GitHub org, we will need to update the link here.

Review

<If complete, or ready for 👀, use @mentions for quick questions, specific feedback, and progress updates.>

cc @parkerbxyz @github/ps-programs for awareness and review 👀

brianamarie added 2 commits Aug 17, 2020
@hollenberry
Copy link
Contributor

@hollenberry hollenberry commented Aug 17, 2020

🎉 🎉 🎉

@parkerbxyz parkerbxyz mentioned this pull request Aug 17, 2020
0 of 4 tasks complete
@brianamarie
Copy link
Contributor Author

@brianamarie brianamarie commented Sep 4, 2020

@github/ps-programs @parkerbxyz Would anyone have a few minutes to review this? Once this is merged, I think we can build on it with #765, and also configure a redirect from training.github.com to the landing page for training kit.

@brianamarie brianamarie merged commit 9ce5696 into master Sep 7, 2020
3 checks passed
3 checks passed
build
Details
Page Build GitHub Pages successfully built your site.
Details
github/pages GitHub Pages successfully built your site.
Details
@brianamarie brianamarie deleted the add-manual-links branch Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.