Skip to content

/ wiki

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VSCode remote development #1533

Merged
merged 2 commits into from Feb 28, 2020
Merged

Add support for VSCode remote development #1533

merged 2 commits into from Feb 28, 2020

Conversation

@LuckyF
Copy link
Contributor

LuckyF commented Feb 26, 2020

This feature enables developers a fast and easy start with the new Remote Container Development feature of VSCode.

To getting started:

  1. Install the "Remote Development" extension pack (ms-vscode-remote.vscode-remote-extensionpack)
  2. Copy "/dev/docker-postgres/sample.yml" to "/config.yml"
  3. Open Workspace in Container

This feature uses the postgress docker development strategy.
Resolves my feature request from last year.

@NGPixel: I also can provide a more detailed introduction in the docs.
@LuckyF
Add support for VSCode remote development
4895b32
@auto-assign auto-assign bot requested a review from NGPixel Feb 26, 2020
@NGPixel
misc: remote dev containers fixes
0d619a9
@NGPixel NGPixel merged commit a90dc8d into Requarks:master Feb 28, 2020
@NGPixel
Copy link
Member

NGPixel commented Feb 28, 2020

Made some changes so that the dockerfile, compose and config are inside the dev/containers folder. Putting these files at the root of the project is dangerous as many people will try to run them thinking it's for production.

Also updated the dev documentation to reflect this change:
https://docs.requarks.io/en/dev

Thanks!
@LuckyF
Copy link
Contributor Author

LuckyF commented Mar 7, 2020

You're right.
My intention was not to change too much to get this feature accepted.
Thank you very much for the work!
@LuckyF LuckyF mentioned this pull request Mar 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NGPixel NGPixel

Assignees

@NGPixel NGPixel

Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@LuckyF @NGPixel
You can’t perform that action at this time.