Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image_picker] updated VALID_ARCHS to support iPhone simulator #2761

Merged
merged 3 commits into from Jul 6, 2020

Conversation

@jlalvarez18
Copy link
Contributor

@jlalvarez18 jlalvarez18 commented May 14, 2020

Description

Currently the Image Picker plugin no longer works on Xcode 11.4.1 in the iPhone simulator. I updated the podspec to set the VALID_ARCHS to match other plugins in this project.

Related Issues

Fixes flutter/flutter#51395

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.
@googlebot
Copy link

@googlebot googlebot commented May 14, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jlalvarez18
Copy link
Contributor Author

@jlalvarez18 jlalvarez18 commented May 14, 2020

@googlebot I signed it!

@googlebot
Copy link

@googlebot googlebot commented May 14, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jlalvarez18 jlalvarez18 force-pushed the jlalvarez18:image_picker_ios_fix branch from 29512f3 to fe03ef5 May 14, 2020
jlalvarez18 pushed a commit to jlalvarez18/plugins that referenced this pull request May 14, 2020
Contains code from the following PRs:

flutter#2761
flutter#2755
@jlalvarez18 jlalvarez18 force-pushed the jlalvarez18:image_picker_ios_fix branch 2 times, most recently from 6f47483 to 5c5b30f May 15, 2020
@jlalvarez18
Copy link
Contributor Author

@jlalvarez18 jlalvarez18 commented May 16, 2020

I will wait until reviewed to update the CHANGEDLOG and Pubspec version until approved to avoid all the merge conflicts :)

@jlubeck
Copy link

@jlubeck jlubeck commented Jun 10, 2020

Any thoughts on well this will be merged?

@Nash0x7E2
Copy link

@Nash0x7E2 Nash0x7E2 commented Jun 17, 2020

cc: @cyanglaz

@TahaTesser TahaTesser requested a review from jmagman Jun 30, 2020
@jmagman
Copy link
Member

@jmagman jmagman commented Jun 30, 2020

This looks good, thank you for making this change!
The pubspec and CHANGELOG need to be updated, then we'll merge and publish. I can also do this and push to your fork, if you prefer (I know you worked on this more than a month ago).
\cc @cyanglaz

@jmagman jmagman force-pushed the jlalvarez18:image_picker_ios_fix branch from 5c5b30f to f640127 Jul 6, 2020
@jmagman
Copy link
Member

@jmagman jmagman commented Jul 6, 2020

Took the liberty of pushing the CHANGELOG, pubspec version bump, and AUTHORS to add @jlalvarez18.

@jmagman jmagman requested a review from cyanglaz Jul 6, 2020
Copy link
Member

@cyanglaz cyanglaz left a comment

LGTM! Added a line between the version number and the message in CHANGELOG.md

@jmagman
jmagman approved these changes Jul 6, 2020
@jmagman jmagman merged commit a5db6e0 into flutter:master Jul 6, 2020
28 checks passed
28 checks passed
@wip
WIP Ready for review
Details
@cirrus-ci
analyze Task Summary
Details
@cirrus-ci
build-apks+java-test+firebase-test-lab CHANNEL:master PLUGIN_SHARDING:--shardIndex 0 --shardCount 2 Task Summary
Details
@cirrus-ci
build-apks+java-test+firebase-test-lab CHANNEL:master PLUGIN_SHARDING:--shardIndex 1 --shardCount 2 Task Summary
Details
@cirrus-ci
build-apks+java-test+firebase-test-lab CHANNEL:stable PLUGIN_SHARDING:--shardIndex 0 --shardCount 2 Task Summary
Details
@cirrus-ci
build-apks+java-test+firebase-test-lab CHANNEL:stable PLUGIN_SHARDING:--shardIndex 1 --shardCount 2 Task Summary
Details
@cirrus-ci
build-apps+drive-examples Task Summary
Details
@cirrus-ci
build-ipas+drive-examples CHANNEL:master PLUGIN_SHARDING:--shardIndex 0 --shardCount 4 Task Summary
Details
@cirrus-ci
build-ipas+drive-examples CHANNEL:master PLUGIN_SHARDING:--shardIndex 1 --shardCount 4 Task Summary
Details
@cirrus-ci
build-ipas+drive-examples CHANNEL:master PLUGIN_SHARDING:--shardIndex 2 --shardCount 4 Task Summary
Details
@cirrus-ci
build-ipas+drive-examples CHANNEL:master PLUGIN_SHARDING:--shardIndex 3 --shardCount 4 Task Summary
Details
@cirrus-ci
build-ipas+drive-examples CHANNEL:stable PLUGIN_SHARDING:--shardIndex 0 --shardCount 4 Task Summary
Details
@cirrus-ci
build-ipas+drive-examples CHANNEL:stable PLUGIN_SHARDING:--shardIndex 1 --shardCount 4 Task Summary
Details
@cirrus-ci
build-ipas+drive-examples CHANNEL:stable PLUGIN_SHARDING:--shardIndex 2 --shardCount 4 Task Summary
Details
@cirrus-ci
build-ipas+drive-examples CHANNEL:stable PLUGIN_SHARDING:--shardIndex 3 --shardCount 4 Task Summary
Details
@cirrus-ci
build-linux+drive-examples Task Summary
Details
@cirrus-ci
build_all_plugins_apk Task Summary
Details
@cirrus-ci
build_all_plugins_app Task Summary
Details
@cirrus-ci
build_all_plugins_ipa Task Summary
Details
@googlebot
cla/google All necessary CLAs are signed
@cirrus-ci
e2e_web_smoke_test Task Summary
Details
@cirrus-ci
format Task Summary
Details
@cirrus-ci
lint_darwin_plugins PLUGIN_SHARDING:--shardIndex 0 --shardCount 2 Task Summary
Details
@cirrus-ci
lint_darwin_plugins PLUGIN_SHARDING:--shardIndex 1 --shardCount 2 Task Summary
Details
@cirrus-ci
publishable Task Summary
Details
@submit-queue
submit-queue Ready to merge!
Details
@cirrus-ci
test CHANNEL:master Task Summary
Details
@cirrus-ci
test CHANNEL:stable Task Summary
Details
agent3bood added a commit to agent3bood/flutter-plugins that referenced this pull request Jul 10, 2020
ferrazrx added a commit to ferrazrx/plugins that referenced this pull request Jul 16, 2020
jorgefspereira added a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants