Skip to content

/ processing4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract delegate for noise generator functions from PApplet #113

Open
wants to merge 11 commits into
base: master
from
Open

Extract delegate for noise generator functions from PApplet #113

wants to merge 11 commits into from

Conversation

@Minimaximize
Copy link
Contributor

@Minimaximize Minimaximize commented Jul 18, 2020

Extract class for generating perlin noise from PApplet and delegate.

  • Simplifies PApplet by enforcing the single responsibility principle and hiding the implementation details in PerlinNoiseGenerator
  • Make it possible to test the perlin noise functions in isolation
Minimaximize and others added 10 commits Jan 24, 2020
@Minimaximize
Merge pull request #2 from processing/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
a251027 
Merge from source branch
@Minimaximize
Merge branch 'master' of https://github.com/processing/processing4
6c70225
Liam James
Merge branch 'master' of https://github.com/processing/processing4
0e0602d
Liam James
Extract perlin noise functions and delegate
1cab907
Liam James
Extract NoiseGenerator interface to reduce coupling
1d5c7b8
Liam James
Code Cleanup
6316658
Liam James
Remove Example noise generator - reimplement later
9e4766d
Liam James
Fix tests for PerlinNoiseGenerator
6fc5a1c
Liam James
remove 'Some' test utility class and use mockito
5b10009
Liam James
Optimize imports and shim flakey test
3b39caa
@Minimaximize Minimaximize marked this pull request as draft Jul 20, 2020
Liam James
revert removal of test utilities
25e0e15 
This reverts commit 5b10009.

# Conflicts:
#	core/test/processing/core/PerlinNoiseGeneratorTest.java
@Minimaximize Minimaximize marked this pull request as ready for review Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@Minimaximize
You can’t perform that action at this time.