Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing serverUrl assignment of config.news #69

Open
wants to merge 1 commit into
base: master
from

Conversation

@waitingsong
Copy link
Contributor

@waitingsong waitingsong commented Apr 5, 2018

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
Copy link

@HengLiYang HengLiYang left a comment

perfect

@@ -4,6 +4,7 @@ export default () => {
const config: DefaultConfig = {};
config.news = {
pageSize: 20,
serverUrl: '//127.0.0.1',

This comment has been minimized.

@atian25

atian25 Aug 24, 2018
Member

anywhere is using this config ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.