Skip to content

/ argo-cd

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In logs view, request to retrieve logs are refetched unnecessarily #4450

Open
imranismail opened this issue Sep 29, 2020 · 3 comments
Open

In logs view, request to retrieve logs are refetched unnecessarily #4450

imranismail opened this issue Sep 29, 2020 · 3 comments
Labels
bug component:ui good first issue

Comments

@imranismail
Copy link
Contributor

@imranismail imranismail commented Sep 29, 2020

Describe the bug

Even when reaching the end of the log, the request to /logs endpoint are reinvoked causing the UI to restream the logs.

To Reproduce

  1. Create a job that logs to stdout
  2. Let it run to finish
  3. View pod log getting repeated unnecessarily

Expected behavior

Stops request once the end of the log is reached

Screenshots

image

Version

1.7.6
@imranismail imranismail added the bug label Sep 29, 2020
@jessesuen
Copy link
Contributor

@jessesuen jessesuen commented Sep 29, 2020

We may need to special case pods which are in completed state, and not retry retrieval of the logs.
@tetchel
Copy link
Contributor

@tetchel tetchel commented Oct 2, 2020 •
edited

it also looks like this can result in the output being duplicated

image
@tetchel tetchel mentioned this issue Oct 22, 2020
Closed
@darshanime
Copy link
Member

@darshanime darshanime commented Oct 30, 2020

closed in #4696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug component:ui good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@imranismail @darshanime @tetchel @jessesuen
You can’t perform that action at this time.