MarshallOfSound
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
2,663 contributions in the last year
Activity overview
Contributed to
electron/electron,
electron/build-tools,
electron/docs-parser
and 5 other
repositories
Contribution activity
October 2020
- MarshallOfSound/chokidar JavaScript
- MarshallOfSound/fsevents C
- MarshallOfSound/macos-notification-state JavaScript
Created a pull request in electron/electron that received 8 comments
build: auto-push patch file changes
Small bit of code to auto push three way merge patch file changes from CI. Abuses a GH app to do it similar to how trop works Notes: no-notes
+187
−9
•
8
comments
- revert: "fix: reply notifs sometimes destroyed too early" (#25247)
- fix: re-enable the spellchecker when new language list set
- fix: re-enable the spellchecker when new language list set
- build: rename the v8 context snapshot on arm64 macOS builds
- revert: reply notifs sometimes destroyed too early
- revert: reply notifs sometimes destroyed too early
- revert: "fix: reply notifs sometimes destroyed too early"
- build: move to ACR for docker image storage
- fix: update squirrel.mac to handle bug in Big Sur
- feat: add support for preventing the system context menu
- build: experiment with codeql
- build: use https for sysroot download
- chore: tidy up .eslintrc.json
- fix: window.open not accepting size values with "px" at the end
- build: only check patch diffs in testing builds
- chore: bump chromium to 9b2191ea59cba1e2f6da4dbb7dee0 (master)
- build: rename the v8 context snapshot on arm64 macOS builds
- build: drop use of --typeRoots for default_app
- feat: correctly identify permissions when using setPermissionRequestHandler
- docs: revised dark mode feature page
- feat: honor `nativeTheme.themeSource = 'dark'` before creating BrowserWindow on Windows
- docs: fix app 'ready' event arguments
- chore: use auto to avoid repeating type
- fix: ensure object is not used after move
- docs: clarify default value of enableRemoteModule
- chore: prefer empty() check for readability
- docs: Windows Security modifies Chromium checkout
- feat: add support for UNNotificationResponse in app 'ready' event
- refactor: Chromium code style for enum classes
- fix: re-enable the spellchecker when new language list set
- fix: disable use of the vm module in the renderer
- build: lint the npm folder
- fix: release NSAlert properly
- build: Wrap bundles using webpack
- chore: bump @typescript-eslint version
- fix: crash when printing
- build: fix missing dependency resulting in a random build failure
- Some pull request reviews not shown.
- chore: only inject Windows env vars on Windows
- feat: show full depot_tools env
- chore: set divergent branch reconciliation strategy
- feat: enable running specific Electron binaries
- chore: ignore third_party js when formatting
- fix: resolve hang when starting goma
- fix: create fork remote if none exists yet
79
contributions
in private repositories
Oct 1 – Oct 29