Skip to content

/ spec

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flakey test exceeds timeout on CI / specs (macos, 2.7.1) #775

Open
sambostock opened this issue Jun 24, 2020 · 1 comment
Open

Flakey test exceeds timeout on CI / specs (macos, 2.7.1) #775

sambostock opened this issue Jun 24, 2020 · 1 comment

Comments

@sambostock
Copy link
Contributor

@sambostock sambostock commented Jun 24, 2020

There is a test which occasionally exceeds the 30 second timeout on CI / specs (macos, 2.7.1), causing the test suite to fail, even if the changes being tested haven't broken anything.

The following logs are from this run

$ ruby /Users/runner/runners/2.263.0/work/spec/mspec/bin/mspec-run --timeout 30
ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-darwin19]

CVE-2020-10663 is resisted by only creating custom objects if passed create_additions: true or using JSON.load
Example took longer than the configured timeout of 30.0s
@sambostock sambostock mentioned this issue Jun 24, 2020
Merged
@eregon
Copy link
Member

@eregon eregon commented Jun 24, 2020

This is surprising because for me this spec runs in like 5ms.

I'd like to see another instance before bumping the timeout higher.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@eregon @sambostock
You can’t perform that action at this time.