fix(analytics): removed providedIn: 'any' from the service injectable #2605
+2
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When i tried that @yasinkocak it triggers the screen_view event when its not provided. Only way to make it work that i saw was with removing providedIn all together |
|
Interesting, so the theses modules aren't tree-shaking out even if you don't provide them... weird. Let me dig into this a bit and see if we can address in a patch. Thanks for the help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Checklist
yarn install,yarn testrun successfully? yesDescription
The
ScreenTrackingServiceandUserTrackingServicewould automatically be initialised even when not provided meaning you cant turn them off.Code sample
Changed from
@Injectable({ providedIn: 'any' })to
@Injectable()