Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBump to latest eslint-config-fbjs #20029
Merged
+182
−9
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a6e4b62:
|
gaearon
merged commit f668b6c
into
facebook:master
34 checks passed
34 checks passed
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_prod_www_variant
Your tests passed on CircleCI!
Details
|
Cool, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Summary
When running
yarn lint, the console outputs this message:I upgraded the version of
eslint-config-fbjsto latest, and added the peer dependencyeslint-plugin-jsx-a11y. I disabled thejsx-a11yrules that were creating warnings, but I can fix them if you'd prefer that :)Test Plan
Only syntax changes, it should be fine if CI checks pass.