Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upn-api: revert change to finalisation #35777
Open
+6
−4
Conversation
|
Review requested: |
This was referenced Oct 23, 2020
|
Issue to investigate test that is being re-excluded: #35778 |
Codecov Report
@@ Coverage Diff @@
## master #35777 +/- ##
==========================================
- Coverage 87.92% 87.91% -0.01%
==========================================
Files 477 477
Lines 113090 113089 -1
Branches 24630 24628 -2
==========================================
- Hits 99433 99427 -6
Misses 7952 7952
- Partials 5705 5710 +5
|
| @@ -1,6 +1,10 @@ | |||
| 'use strict'; | |||
| const common = require('../../common'); | |||
|
|
|||
| // TODO(addaleax): Run this test once it stops failing under ASAN/valgrind. | |||
| // Refs: https://github.com/nodejs/node/issues/34731 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes: #35620
This reverts commit a6b6556 which
changed finalization behavior related to N-API. We will investigate
the original issue with the test separately.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes