Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove ignore GCC -Wcast-function-type for v8 #35768

Open
wants to merge 1 commit into
base: master
from
Open

src: remove ignore GCC -Wcast-function-type for v8 #35768

wants to merge 1 commit into from
+0 −21

Conversation

@danbev
Copy link
Member

@danbev danbev commented Oct 23, 2020 •
edited

This reverts Commit 3ff2aec ("src: ignore GCC -Wcast-function-type for v8.h") and Commit
2462a2c ("src: fix ignore GCC -Wcast-function-type for older compilers") as this has
now been included in the V8 version being used.

Refs:
v8/v8@f08cbfd

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Oct 23, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33809/
@danbev danbev mentioned this pull request Oct 23, 2020
Open
2 of 2 tasks complete
@codecov-io
Copy link

@codecov-io codecov-io commented Oct 23, 2020

Codecov Report

Merging #35768 into master will decrease coverage by 8.49%.
The diff coverage is 73.80%.

@@            Coverage Diff             @@
##           master   #35768      +/-   ##
==========================================
- Coverage   96.40%   87.90%   -8.50%     
==========================================
  Files         223      477     +254     
  Lines       73685   113090   +39405     
  Branches        0    24627   +24627     
==========================================
+ Hits        71038    99417   +28379     
- Misses       2647     7962    +5315     
- Partials        0     5711    +5711
Impacted Files Coverage Δ
src/base_object-inl.h 78.12% <ø> (ø)
src/node.h 93.33% <ø> (ø)
src/util.h 85.24% <ø> (ø)
src/inspector_profiler.cc 76.17% <69.44%> (ø)
lib/v8.js 99.65% <100.00%> (-0.35%) ⬇️
src/inspector_profiler.h 86.95% <100.00%> (ø)
lib/internal/idna.js 55.55% <0.00%> (-11.12%) ⬇️
lib/internal/blocklist.js 88.70% <0.00%> (-10.49%) ⬇️
lib/internal/crypto/mac.js 73.45% <0.00%> (-9.48%) ⬇️
lib/internal/modules/esm/get_format.js 84.72% <0.00%> (-8.34%) ⬇️
... and 395 more
@targos
targos approved these changes Oct 23, 2020
View changes
@Trott
Trott approved these changes Oct 23, 2020
View changes
Copy link
Member

@Trott Trott left a comment

LGTM. Might be worth double-checking the commit message text to make sure it's what you intended.
@danbev
src: remove ignore GCC -Wcast-function-type for v8
Loading status checks…
3ae98ac 
This reverts Commit 3ff2aec ("src:
ignore GCC -Wcast-function-type for v8.h") and Commit
2462a2c ("src: fix ignore GCC
-Wcast-function-type for older compilers") as this has
now been included in the V8 version being used.

Refs:
v8/v8@f08cbfd
@danbev danbev force-pushed the danbev:remove-gcc-cast-function-type2 branch from f2f788f to 3ae98ac Oct 23, 2020
@danbev
Copy link
Member Author

@danbev danbev commented Oct 23, 2020

Might be worth double-checking the commit message text to make sure it's what you intended

Thanks for pointing that out, it was not very clear.
@JungMinu
JungMinu approved these changes Oct 25, 2020
View changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott

@targos targos

@JungMinu JungMinu

Assignees
No one assigned
Labels
C++ dont-land-on-v10.x dont-land-on-v12.x dont-land-on-v14.x
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@danbev @nodejs-github-bot @codecov-io @Trott @targos @JungMinu
You can’t perform that action at this time.